Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "poetry lock --no-update" so that dependencies with extras are not updated unnecessarily #4618

Conversation

radoering
Copy link
Member

@radoering radoering commented Oct 9, 2021

Pull Request Check List

Resolves: #4612
Resolves: #3128
Resolves: #5185

  • Added tests for changed code.
  • Updated documentation for changed code.

When calling poetry lock with --no-update dependencies with extras should not be updated unnecessarily.

@neersighted neersighted self-assigned this Nov 13, 2021
@radoering
Copy link
Member Author

@neersighted: Shall I rebase the branch so that the FreeBSD test can succeed or should I wait for your review?

@neersighted
Copy link
Member

neersighted commented Nov 14, 2021

@neersighted: Shall I rebase the branch so that the FreeBSD test can succeed or should I wait for your review?

Please go ahead and rebase! There are enough changes in master that even non-significantly stale PRs will need to be rebased to have confidence in testing anyway. Thanks!

@radoering radoering force-pushed the fix-lock-no-update-for-deps-with-extras branch 3 times, most recently from 764a964 to 8b5b090 Compare November 21, 2021 05:44
src/poetry/mixology/version_solver.py Outdated Show resolved Hide resolved
src/poetry/mixology/version_solver.py Outdated Show resolved Hide resolved
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants