pyproject: Drop python 3.6

[tony]

Resolves: #4997

Pull Request Check List

• Requires Deprecate Python 3.6 poetry-core#263
• See also: Deprecate Python 3.6 install.python-poetry.org#11

Resolves: #4997

• Added tests for changed code.
• Updated documentation for changed code.

[neersighted]

There are a couple more things to do here, I think:

• the Python version in .flake8
• the arguments to pyupgrade in .pre-commit-config.yaml

[tony]

There are a couple more things to do here, I think:

• the Python version in .flake8
• the arguments to pyupgrade in .pre-commit-config.yaml

I will convert it to a draft, handle those things, and also continue to look for any other places

If you notice anything else let me know

[tony]

pre-commit.ci autofix

[neersighted]

Looks like we can drop the dataclasses dep as the marker (python = "<3.7") makes it a no-op.

I don't have time to look into this, but I also suspect this line can be dropped as the types should be in the stdlib now. I may be wrong, so please look into it before making that change.

[tony]

@neersighted

• Dropped dataclasses
  • poetry-core: Also already dropped dataclasses in Deprecate Python 3.6 poetry-core#263
• types-dataclasses: removed

[tony]

@branchvincent: Thank you

Rebased.

Can you approve running on python-poetry/poetry-core#263?

[tony]

@branchvincent

P.S.

Any preference on how to navigate this? I can merge the commits into mine or re-do them myself.

[branchvincent]

Can you approve running on python-poetry/poetry-core#263?

Unfortunately I don't have access yet 😓 , I've just started helping here. I'll see if I can find someone who does

cc @finswimmer?

Any preference on how to navigate this?

Thanks for checking, but it's fine as is! I only have it as a requirement for another project

I believe there's one more version-gated block we can remove:

poetry/src/poetry/utils/pip.py

Lines 58 to 69 in 28d05d0

	if sys.version_info < (3, 7) and not is_wheel:
	# Under certain Python3.6 installs vendored pip wheel does not contain
	# zip-safe pep517 lib. In this cases we create an isolated ephemeral virtual
	# environment.
	with ephemeral_environment(
	executable=environment.python, with_pip=True, with_setuptools=True
	) as env:
	return environment.run(
	*env.get_pip_command(),
	*args,
	env={**os.environ, "PYTHONPATH": str(env.purelib)},
	)

[branchvincent]

Thanks @tony, this looks good to me. Let's get one more reviewer to approve/merge

[tony]

Thanks @tony, this looks good to me. Let's get one more reviewer to approve/merge

Thank you for the review!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.