Csv fixes #5836
Merged
Csv fixes #5836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dimbleby any chance we can add a simple test somewhere for this to ensure we do not regress? |
|
tweaked some unit test. In particular the assertion that all entries are of length 3 ought to catch #5799 (though I don't have a suitable environment to confirm that this failed without the fix) |
dimbleby
force-pushed
the
csv-fixes
branch
2 times, most recently
from
4ed49b7
to
4c026d5
Compare
neersighted
approved these changes
Jun 13, 2022
|
Wow, that was a quick turnaround! I can confirm that this fixes the RECORD issue on Windows, the repro I had made runs clean when using the latest git version of poetry. Thanks for all your work on poetry! 🎉 |
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for handling the csv RECORD file
First, open the file with
newline="". Per https://docs.python.org/3/library/csv.html#id3I'm almost sure this will fix #5799, although since I don't have a Windows environment of my own I can't prove it.
Then while I was there I noticed that poetry really ought to use
csvin the other place that it creates this file, to make sure that escaping of funny filenames and suchlike happens properly. cf python-poetry/poetry-core#61