-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve symlinks in locker.lock path to real physical paths #5850
Conversation
9066eca
to
d0c15a2
Compare
Having some trouble getting the new test to pass on Windows. Windows Python < 3.8 does not resolve symlinks at all using The suggestion is instead to use Few options we can take:
Will try out option 1 Edit: Option 1 passes the checks |
Could I get a review for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nitpicks in the test.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #5849
Pull Request Check List
Resolves: #5849