Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix example for --with option combined with --without #6318

Merged

Conversation

morpser
Copy link
Contributor

@morpser morpser commented Sep 1, 2022

The current "Managing Dependencies" documentation contains an error at
Installing group dependencies

Within the warning concerning the combined use of --with and --without the parameters were swapped.

  • Added tests for changed code.
  • Updated documentation

@finswimmer finswimmer added the area/docs Documentation issues/improvements label Sep 1, 2022
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Deploy preview for website ready!

✅ Preview
https://website-40apvejcy-python-poetry.vercel.app

Built with commit fc05fbd.
This pull request is being automatically deployed with vercel-action

Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

I added one suggestion for further improvement of this section.

docs/managing-dependencies.md Outdated Show resolved Hide resolved
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@finswimmer finswimmer changed the title Fix docu for --with option docs: fix example for --with option combined with --without Sep 1, 2022
@finswimmer finswimmer merged commit a613347 into python-poetry:master Sep 1, 2022
github-actions bot pushed a commit that referenced this pull request Sep 2, 2022
The current "Managing Dependencies" documentation contains an error at
[Installing group dependencies](https://python-poetry.org/docs/managing-dependencies/#installing-group-dependencies)

Within the warning concerning the combined use of  `--with` and `--without` the parameters were swapped.

- [ ] Added **tests** for changed code.
- [x] Updated **documentation**

Co-authored-by: Philipp Quenzel <[email protected]>
Co-authored-by: finswimmer <[email protected]>
(cherry picked from commit a613347)
poetry-bot bot pushed a commit that referenced this pull request Sep 2, 2022
The current "Managing Dependencies" documentation contains an error at
[Installing group dependencies](https://python-poetry.org/docs/managing-dependencies/#installing-group-dependencies)

Within the warning concerning the combined use of  `--with` and `--without` the parameters were swapped.

- [ ] Added **tests** for changed code.
- [x] Updated **documentation**

Co-authored-by: Philipp Quenzel <[email protected]>
Co-authored-by: finswimmer <[email protected]>
(cherry picked from commit a613347)
branchvincent pushed a commit that referenced this pull request Sep 2, 2022
The current "Managing Dependencies" documentation contains an error at
[Installing group dependencies](https://python-poetry.org/docs/managing-dependencies/#installing-group-dependencies)

Within the warning concerning the combined use of  `--with` and `--without` the parameters were swapped.

- [ ] Added **tests** for changed code.
- [x] Updated **documentation**

Co-authored-by: Philipp Quenzel <[email protected]>
Co-authored-by: finswimmer <[email protected]>
(cherry picked from commit a613347)
@neersighted neersighted added this to the 1.3 milestone Sep 17, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants