-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix example for --with option combined with --without #6318
docs: fix example for --with option combined with --without #6318
Conversation
Deploy preview for website ready! ✅ Preview Built with commit fc05fbd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
I added one suggestion for further improvement of this section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥇
The current "Managing Dependencies" documentation contains an error at [Installing group dependencies](https://python-poetry.org/docs/managing-dependencies/#installing-group-dependencies) Within the warning concerning the combined use of `--with` and `--without` the parameters were swapped. - [ ] Added **tests** for changed code. - [x] Updated **documentation** Co-authored-by: Philipp Quenzel <[email protected]> Co-authored-by: finswimmer <[email protected]> (cherry picked from commit a613347)
The current "Managing Dependencies" documentation contains an error at [Installing group dependencies](https://python-poetry.org/docs/managing-dependencies/#installing-group-dependencies) Within the warning concerning the combined use of `--with` and `--without` the parameters were swapped. - [ ] Added **tests** for changed code. - [x] Updated **documentation** Co-authored-by: Philipp Quenzel <[email protected]> Co-authored-by: finswimmer <[email protected]> (cherry picked from commit a613347)
The current "Managing Dependencies" documentation contains an error at [Installing group dependencies](https://python-poetry.org/docs/managing-dependencies/#installing-group-dependencies) Within the warning concerning the combined use of `--with` and `--without` the parameters were swapped. - [ ] Added **tests** for changed code. - [x] Updated **documentation** Co-authored-by: Philipp Quenzel <[email protected]> Co-authored-by: finswimmer <[email protected]> (cherry picked from commit a613347)
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The current "Managing Dependencies" documentation contains an error at
Installing group dependencies
Within the warning concerning the combined use of
--with
and--without
the parameters were swapped.