Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify marker simplification #7136

Merged
merged 1 commit into from
Dec 11, 2022
Merged

simplify marker simplification #7136

merged 1 commit into from
Dec 11, 2022

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Dec 3, 2022 •
edited
Loading

The simplification and generalization of marker parsing and merging in python-poetry/poetry-core#530 results in markers being parsed to disjunctive normal form.

Obviously needs coordination with python-poetry/poetry-core#530

@radoering
Copy link
Member

Can we just make the test forward compatible like assert marker in [variant1, variant2] to keep coordination simple? I think we can even keep this after the next core release so we don't have to adapt the test again if the marker changes to the original variant for some reason in the future.

@dimbleby dimbleby force-pushed the simplify-marker-simplification branch from 4774b08 to c2c9347 Compare December 10, 2022 14:14
@radoering radoering force-pushed the simplify-marker-simplification branch from c2c9347 to 6f3f712 Compare December 11, 2022 11:47
@radoering radoering added impact/backport Requires backport to stable branch backport/1.3 labels Dec 11, 2022
@radoering radoering enabled auto-merge (squash) December 11, 2022 11:50
@radoering radoering merged commit 0c8e5b4 into python-poetry:master Dec 11, 2022
@poetry-bot poetry-bot bot mentioned this pull request Dec 11, 2022
Merged
poetry-bot bot pushed a commit that referenced this pull request Dec 11, 2022
@dimbleby @github-actions
tests: make tests forward compatible with simplified marker simplific…
6e045db 
…ation (#7136)

(cherry picked from commit 0c8e5b4)
@dimbleby dimbleby deleted the simplify-marker-simplification branch December 11, 2022 11:54
radoering pushed a commit that referenced this pull request Dec 11, 2022
@dimbleby @radoering
tests: make tests forward compatible with simplified marker simplific…
f8e24fc 
…ation (#7136)

(cherry picked from commit 0c8e5b4)
@neersighted neersighted added this to the 1.4 milestone Jan 15, 2023
@neersighted neersighted added area/solver Related to the dependency resolver kind/refactor Pulls that refactor, or clean-up code labels Jan 15, 2023
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radoering radoering radoering approved these changes

Assignees
No one assigned
Labels
area/solver Related to the dependency resolver impact/backport Requires backport to stable branch kind/refactor Pulls that refactor, or clean-up code
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@dimbleby @radoering @neersighted