Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when invalid groups are referenced #7529

Merged
merged 7 commits into from
Apr 5, 2023
Merged

Error when invalid groups are referenced #7529

merged 7 commits into from
Apr 5, 2023

Commits on Apr 5, 2023

  1. Warning when invalid groups are referenced

    @samypr100
    samypr100 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    141f4fb View commit details
    Browse the repository at this point in the history

  2. Update src/poetry/console/commands/group_command.py 

    Co-authored-by: Randy Döring <[email protected]>
    @samypr100 @radoering
    samypr100 and radoering committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    70207f9 View commit details
    Browse the repository at this point in the history

  3. Raise error when encountering invalid groups

    @samypr100
    samypr100 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    90c5489 View commit details
    Browse the repository at this point in the history

  4. Addressing PR feedback 

    Removing extraneous docs
Collapsing error output into single Exception
Migrating GroupNotFound to console.exceptions
    @samypr100
    samypr100 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    bcd5401 View commit details
    Browse the repository at this point in the history

  5. Simplifying Exception Message

    @samypr100
    samypr100 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    08ab3ea View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Randy Döring <[email protected]>
    @samypr100 @radoering
    samypr100 and radoering committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    fe83b63 View commit details
    Browse the repository at this point in the history

  7. Post feedback cleanup

    @samypr100
    samypr100 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    25ae7c7 View commit details
    Browse the repository at this point in the history