prefer stdlib TemporaryDirectory #7680
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimbleby
force-pushed
the
temporary-directory
branch
from
9e5031d
to
5746e62
Compare
dimbleby
force-pushed
the
temporary-directory
branch
2 times, most recently
from
c1d26e2
to
84ac784
Compare
dimbleby
force-pushed
the
temporary-directory
branch
from
84ac784
to
e6620c8
Compare
eamanu
previously approved these changes
May 14, 2023
In fact python-poetry/poetry-core#460 seems to leave poetry committed to its own implementation until support for python 3.9 (or windows!) can be dropped |
dimbleby
force-pushed
the
temporary-directory
branch
from
e6620c8
to
8c7cd5f
Compare
|
@dimbleby try to avoid force push |
|
@eamanu thanks but no thanks. per my last comment this is unlikely to be merged for quite some time and it is absolutely more sensible that when that time comes it will be best represented as a single commit on top of All due respect but you have now made two low-value comments on this MR, please stop. |
dimbleby
force-pushed
the
temporary-directory
branch
from
8c7cd5f
to
1e8e831
Compare
dimbleby
force-pushed
the
temporary-directory
branch
from
1e8e831
to
daf5147
Compare
dimbleby
force-pushed
the
temporary-directory
branch
from
daf5147
to
ddc6ecc
Compare
dimbleby
force-pushed
the
temporary-directory
branch
from
ddc6ecc
to
8b66b68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dropping python 3.7 per #7674 moves poetry past the Windows python 3.7 bugs that made the homegrown
temporary_directory()worthwhile