-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treat collection types in package as immutable #8671
Conversation
python-poetry/poetry-core#663 is the companion MR and, not for the first time, it will be awkward to find a sequence of merges that keeps both pipelines happy throughout Edit: I take it back, it's possible to merge the poetry-core one first - because the pipelines in poetry-core don't run mypy over poetry proper |
a93aed2
to
014443a
Compare
@dimbleby I suppose we have to update poetry-core in this PR to pass mypy. Do you have the time to take care of it? |
gonna need to upgrade poetry core for lots of reasons though, right? I'd think that wants handling in a separate MR and then this one can simply merge / rebase either way I wont' be doing anything before the weekend, probably can find time then though. |
I assumed that mypy would fail after upgrading poetry-core without the changes of this PR but I'll try if it's possible to do it separately or if other things break. (I have the hope that all other things are just deprecation warnings we can address later.) |
014443a
to
9bd1a27
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
addresses #8250, #7459: but the interesting part of the fix is in poetry-core and I'll make more comments there