Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treat collection types in package as immutable #8671

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

dimbleby
Copy link
Contributor

addresses #8250, #7459: but the interesting part of the fix is in poetry-core and I'll make more comments there

@dimbleby
Copy link
Contributor Author

dimbleby commented Nov 14, 2023

python-poetry/poetry-core#663 is the companion MR and, not for the first time, it will be awkward to find a sequence of merges that keeps both pipelines happy throughout

Edit: I take it back, it's possible to merge the poetry-core one first - because the pipelines in poetry-core don't run mypy over poetry proper

@radoering radoering mentioned this pull request Dec 9, 2023
@dimbleby dimbleby force-pushed the shallow-copy branch 2 times, most recently from a93aed2 to 014443a Compare January 27, 2024 19:06
@Secrus Secrus added the status/waiting-on-core Requires changes to poetry-core first label Jan 30, 2024
@radoering
Copy link
Member

@dimbleby I suppose we have to update poetry-core in this PR to pass mypy. Do you have the time to take care of it?

@radoering radoering removed the status/waiting-on-core Requires changes to poetry-core first label Feb 2, 2024
@dimbleby
Copy link
Contributor Author

dimbleby commented Feb 2, 2024

gonna need to upgrade poetry core for lots of reasons though, right? I'd think that wants handling in a separate MR and then this one can simply merge / rebase

either way I wont' be doing anything before the weekend, probably can find time then though.

@radoering
Copy link
Member

I'd think that wants handling in a separate MR and then this one can simply merge / rebase

I assumed that mypy would fail after upgrading poetry-core without the changes of this PR but I'll try if it's possible to do it separately or if other things break. (I have the hope that all other things are just deprecation warnings we can address later.)

@radoering radoering merged commit a68aed6 into python-poetry:master Feb 2, 2024
20 checks passed
@dimbleby dimbleby deleted the shallow-copy branch February 2, 2024 18:16
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants