[1.8 backport] inspection: error on unsupported metadata versions #9229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this is without the test as it did not apply cleanly; let me know if you want me to try to bring it forward as well. |
abn
previously approved these changes
Mar 24, 2024
jfly
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
I haven't manually tested this version with my test harness, but the code LGTM!
Previously, when processing wheel files, PackageInfo incorrectly returned an empty instance. This change ensures a PackageInfoError is correctly raised. (cherry picked from commit 23612d4)
Resolves: python-poetry#9195 (cherry picked from commit 2a2abce)
I thought this would be nice just to help people debug things in the future. (cherry picked from commit 8b9cf46)
radoering
force-pushed
the
backport/9203-1.8
branch
from
d0abffb
to
ebd6a3d
Compare
radoering
approved these changes
Apr 22, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #9203 to 1.8.
Resolves: #9195
This change also handles a previously unidentified bug. Previously, when processing wheel files,
PackageInfoincorrectlyreturned an empty instance. This change ensures a
PackageInfoErroris correctly raised. See 36bf325.