Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove no-setuptools config option #9331

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Apr 23, 2024

it is currently mildly inconsistent that poetry defaults to installing setuptools in newly created environments, but then removing it at poetry install --sync

the direction of travel is that setuptools should be named as an explicit dependency if required, let's go there

  • remove the config option
  • don't install setuptools

maybe one for #9136 if that's going to be a thing, though personally I would not be too frightened of releasing this anyway, so long as it gets a suitable mention in the changelog

@Secrus
Copy link
Member

Secrus commented Sep 15, 2024

@dimbleby could you please rebase?

@dimbleby
Copy link
Contributor Author

@dimbleby could you please rebase?

@Secrus there are no merge conflicts, you can just hit the "rebase and merge" button

@Secrus Secrus enabled auto-merge (rebase) September 15, 2024 10:47
@Secrus Secrus enabled auto-merge (squash) September 15, 2024 10:48
auto-merge was automatically disabled September 15, 2024 11:40

Head branch was pushed to by a user without write access

@Secrus Secrus enabled auto-merge (squash) September 16, 2024 09:43
@Secrus Secrus merged commit 65b611a into python-poetry:main Sep 16, 2024
76 checks passed
@dimbleby dimbleby deleted the no-no-setuptools branch September 16, 2024 10:02
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants