Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid race conditions when installing multiple dependencies from the same git repository. #9658

Merged
merged 9 commits into from
Sep 27, 2024
Merged

Avoid race conditions when installing multiple dependencies from the same git repository. #9658

merged 9 commits into from
Sep 27, 2024

Commits on Sep 27, 2024

  1. executor: avoid race condition for git dependency 

    Multiple installs from the same git repository causes arace condition
when the repository is cloned.
This commit only allows one operation per repository to be executed by
the parallel workers.
Any extra operation will be performed serially.
Since the git repository is cached after the first operation, this is
blazingly fast.

Resolves: python-poetry#6958
    @gustavgransbo @radoering
    gustavgransbo authored and radoering committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    73f1b2b View commit details
    Browse the repository at this point in the history

  2. Test installing multiple packages from same repo

    @gustavgransbo @radoering
    gustavgransbo authored and radoering committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    30ced26 View commit details
    Browse the repository at this point in the history

  3. Only serialize git operations with same priority

    @gustavgransbo @radoering
    gustavgransbo authored and radoering committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    409315c View commit details
    Browse the repository at this point in the history

  4. Execute git operations serially per repository 

    Operations for a single repository are grouped and executed serially by
a single worker.
    @gustavgransbo @radoering
    gustavgransbo authored and radoering committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d1af137 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary use of functools.partial

    @gustavgransbo @radoering
    gustavgransbo authored and radoering committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a1a7e55 View commit details
    Browse the repository at this point in the history

  6. Mark skipped operations parallel safe 

    This simplifies the subsequent if/else block.
    @gustavgransbo @radoering
    gustavgransbo authored and radoering committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    fc3a2af View commit details
    Browse the repository at this point in the history

  7. Move inner function to class

    @gustavgransbo @radoering
    gustavgransbo authored and radoering committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    39a9631 View commit details
    Browse the repository at this point in the history

  8. Revert "Move inner function to class" 

    This reverts commit 58e5338.
    @gustavgransbo @radoering
    gustavgransbo authored and radoering committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c9b1630 View commit details
    Browse the repository at this point in the history

  9. Move _serialize out of loop

    @gustavgransbo @radoering
    gustavgransbo authored and radoering committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    259100f View commit details
    Browse the repository at this point in the history