Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #304: pass along ordered parameter #326

Merged
merged 1 commit into from
May 27, 2021

Conversation

bdscharf
Copy link
Contributor

@bdscharf bdscharf commented May 26, 2021

This resolves issue #304. The ordered parameter was not being passed along to output() in one case. It is now passed, and items are popped from the front to retain the original order. Original behavior is kept in case someone needs/wants it.

Test case also added to check ordered vs. not ordered.

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #326 (0a9ec62) into master (a39e06f) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
- Coverage   96.81%   96.77%   -0.04%     
==========================================
  Files          20       20              
  Lines        2730     2732       +2     
==========================================
+ Hits         2643     2644       +1     
- Misses         87       88       +1     
Impacted Files Coverage Δ
flask_restx/fields.py 96.43% <66.66%> (-0.21%) ⬇️
flask_restx/marshalling.py 98.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a39e06f...0a9ec62. Read the comment docs.

@bdscharf
Copy link
Contributor Author

Will look into resolving the coverage gap.

@j5awry
Copy link
Contributor

j5awry commented May 27, 2021

Don't worry about the gap -- CodeCov is complaining at a unit level that ordering in fields isn't covered. However, functionally, it is covered by the test provided. If the pop didn't work, you wouldn't have the expected outcome in the test of marshalling.

@j5awry j5awry merged commit 409dc7a into python-restx:master May 27, 2021
@bdscharf bdscharf deleted the bdscharf/issue-304 branch May 27, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants