-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix PermissionError due to accessing pthreads upon importing trio #2693
Conversation
f61b60e
to
88a1c2f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2693 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 113 113
Lines 16474 16475 +1
Branches 3004 3004
=======================================
+ Hits 16283 16284 +1
Misses 134 134
Partials 57 57
|
CI fail is due to #2689 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really know if this works cause not my kinda thing. Would be happy to merge and get a quick fix out though, just please add a news fragment!
Actually we can probably ask the original issue reporter to test this. I forgot the syntax to make pip install from a specific branch :( |
ah oops, I wrote a newsfragment but looks like I forgot to add the file |
@chrisbeardy would you mind installing trio from this branch and seeing if it works? https://stackoverflow.com/questions/20101834/pip-install-from-git-repo-branch |
Yep will do, give me a day or so as away for the weekend |
Can confirm this imports ok now "on my machine" |
Awesome! It's the only data point we have about it not working, so that's good enough for me. Feel free to merge and maybe push out a quick bugfix release if the newsfragment looks good (otherwise just edit it directly) @A5rocks |
quickfix for #2688