Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PermissionError due to accessing pthreads upon importing trio #2693

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Jul 7, 2023

quickfix for #2688

@jakkdl jakkdl force-pushed the permission_error_pthreads branch from f61b60e to 88a1c2f Compare July 7, 2023 13:17
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #2693 (2e233c7) into master (6d71047) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2693   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         113      113           
  Lines       16474    16475    +1     
  Branches     3004     3004           
=======================================
+ Hits        16283    16284    +1     
  Misses        134      134           
  Partials       57       57           
Impacted Files Coverage Δ
trio/_core/_thread_cache.py 100.00% <100.00%> (ø)

@jakkdl
Copy link
Member Author

jakkdl commented Jul 7, 2023

CI fail is due to #2689 (comment)

Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know if this works cause not my kinda thing. Would be happy to merge and get a quick fix out though, just please add a news fragment!

@A5rocks
Copy link
Contributor

A5rocks commented Jul 8, 2023

Actually we can probably ask the original issue reporter to test this. I forgot the syntax to make pip install from a specific branch :(

@jakkdl
Copy link
Member Author

jakkdl commented Jul 8, 2023

ah oops, I wrote a newsfragment but looks like I forgot to add the file

@jakkdl
Copy link
Member Author

jakkdl commented Jul 8, 2023

@chrisbeardy would you mind installing trio from this branch and seeing if it works? https://stackoverflow.com/questions/20101834/pip-install-from-git-repo-branch

@chrisbeardy
Copy link

Yep will do, give me a day or so as away for the weekend

@chrisbeardy
Copy link

Can confirm this imports ok now "on my machine"

@jakkdl jakkdl requested a review from A5rocks July 11, 2023 10:50
@jakkdl
Copy link
Member Author

jakkdl commented Jul 11, 2023

Can confirm this imports ok now "on my machine"

Awesome! It's the only data point we have about it not working, so that's good enough for me. Feel free to merge and maybe push out a quick bugfix release if the newsfragment looks good (otherwise just edit it directly) @A5rocks

@A5rocks A5rocks merged commit 1687f5d into python-trio:master Jul 11, 2023
@jakkdl jakkdl deleted the permission_error_pthreads branch July 12, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants