Enable flake8-bugbear rule #2807
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2807 +/- ##
==========================================
+ Coverage 99.13% 99.15% +0.02%
==========================================
Files 115 115
Lines 17242 17261 +19
Branches 3085 3086 +1
==========================================
+ Hits 17093 17116 +23
+ Misses 104 101 -3
+ Partials 45 44 -1
|
| "RUF", # Ruff-specific rules | ||
| "E", # Error | ||
| "F", # pyflakes | ||
| "E", # Error | ||
| "W", # Warning | ||
| "I", # isort | ||
| "B", # flake8-bugbear | ||
| "YTT", # flake8-2020 |
There was a problem hiding this comment.
you moved "E" ... probably want this list sorted?
There was a problem hiding this comment.
We should consider running a toml-formatter in pre-commit that does it automatically
| ( | ||
| SSL.OP_NO_QUERY_MTU | ||
| | SSL.OP_NO_RENEGOTIATION # type: ignore[attr-defined] | ||
| ) | ||
| SSL.OP_NO_QUERY_MTU | SSL.OP_NO_RENEGOTIATION # type: ignore[attr-defined] |
There was a problem hiding this comment.
is this formatting change due to a version bump?
There was a problem hiding this comment.
It's changed by black funnily enough, not ruff.
Tested with reverting changes and running pre-commit locally.
There was a problem hiding this comment.
Well, it's a good change - but I'm confused why it's in this PR and not in a separate PR that does the actual version bump in the committed config file.
All but the one in `trio/_tests/test_socket.py` line 390 because it already has a lot of comments
This PR enables the flake8-bugbear rule and fixes all the existing issues that were raised.