switch to PEP 621 #2860
Merged
switch to PEP 621 #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2860 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 115 115
Lines 17611 17611
Branches 3149 3149
=======================================
Hits 17468 17468
Misses 99 99
Partials 44 44
|
graingert
commented
Nov 4, 2023
graingert
commented
Nov 4, 2023
agronholm
reviewed
Nov 4, 2023
agronholm
reviewed
Nov 4, 2023
agronholm
reviewed
Nov 4, 2023
agronholm
reviewed
Nov 4, 2023
agronholm
reviewed
Nov 4, 2023
Co-authored-by: Thomas Grainger <[email protected]>
agronholm
approved these changes
Nov 4, 2023
webknjaz
reviewed
Nov 4, 2023
| ] | ||
| requires-python = ">=3.8" | ||
| dependencies = [ | ||
| # attrs 19.2.0 adds `eq` option to decorators |
There was a problem hiding this comment.
Do we really need to keep this comment about some older version boundary?
There was a problem hiding this comment.
Comments were in the original setup.py so I maintained them in the pyproject.toml
| "idna", | ||
| "outcome", | ||
| "sniffio >= 1.3.0", | ||
| # cffi 1.12 adds from_buffer(require_writable=True) and ffi.release() |
There was a problem hiding this comment.
Same: the older version comment is probably unnecessary.
There was a problem hiding this comment.
Comments were in the original setup.py so I maintained them in the pyproject.toml
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
webknjaz
reviewed
Nov 4, 2023
webknjaz
approved these changes
Nov 4, 2023
|
Sorry, didn't see this. Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simpler version of https://github.com/python-trio/trio/pull/2449/files that keeps setuptools and continues parsing the version out of
trio/_version.pyrather than addingsetuptools-scm