Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Continuous Integration to ZooKeeper 3.5.3-beta #477

Closed
tgockel opened this issue Aug 24, 2017 · 9 comments
Closed

Update Continuous Integration to ZooKeeper 3.5.3-beta #477

tgockel opened this issue Aug 24, 2017 · 9 comments

Comments

@tgockel
Copy link
Contributor

tgockel commented Aug 24, 2017

Currently, .travis.yml uses the to-be-released ZOOKEEPER_VERSION=3.5.2-alpha. The current release (as of 2017-08-24) of the 3.5 line is 3.5.3-beta. Unless there is some motivation to continue to test against the old ZK server, .travis.yml should be updated to use the newer version.

@jeffwidman
Copy link
Member

Great idea!

Pull request welcome if you want to update it. Otherwise I'll try to do it in the next week or so.

tgockel added a commit to tgockel/kazoo that referenced this issue Aug 28, 2017
…python-zk#477)

There is no need to test this library against the Alpha line of ZooKeeper, so
this uses the most up-to-date ZooKeeper server release.

Closes python-zk#477
@tgockel
Copy link
Contributor Author

tgockel commented Aug 28, 2017

So this is somewhat annoying...it seems that the file fetched in ensure-zookeeper-env will be zookeeper-3.5.3-beta.tar.gz. Despite the .tar.gz file suffix, it is actually a non-gzipped tarball, which makes the tar -zx fail. Changing this to tar -x works, but of course breaks all the properly-compressed files. Aside from opening a bug against ZK's packaging, I'm not sure what to here.

@jeffwidman
Copy link
Member

Ugh, that's no fun.

Can you open a ticket on the Zookeeper Jira and link back to it here?

Generally I've found that team is reasonably responsive, especially to something like this which sounds like a very annoying packaging bug that is likely to bite a lot of folks.

@tgockel
Copy link
Contributor Author

tgockel commented Aug 30, 2017

Bug is ZOOKEEPER-2885. Hopefully I'll get an email when it's fixed.

@jeffwidman
Copy link
Member

Perfect, as long as you're a watcher on the JIRA ticket you'll get an email...

tgockel added a commit to tgockel/kazoo that referenced this issue Aug 30, 2017
…python-zk#477)

There is no need to test this library against the Alpha line of ZooKeeper, so
this uses the most up-to-date ZooKeeper server release.

Closes python-zk#477
@jeffwidman
Copy link
Member

@tgockel now that this is fixed upstream, do you want to submit a PR containing your commit that fixes this?

@tgockel
Copy link
Contributor Author

tgockel commented Sep 9, 2017

It's marked as fixed, but the file hasn't propagated out to everywhere...there's some likelihood that it will not ever in a lot of mirrors, since people usually expect artifacts to be permanent.

@jeffwidman
Copy link
Member

jeffwidman commented Sep 12, 2017

I assume from your comment that it's breaking on Travis still... That's a bummer. I guess we'll just have to wait for 3.5.4 to drop.

@tgockel
Copy link
Contributor Author

tgockel commented Sep 12, 2017

Yeah...3.5.3 is beta anyway :-)

StephenSorriaux added a commit to StephenSorriaux/kazoo that referenced this issue Oct 1, 2018
Version of Zookeeper is upgraded from 3.5.2-alpha to 3.5.4-beta for automated tests.
Reconfig now needs superuser authentification, a test is added to cover this feature.
Additionnal configuration and jvm parameters can be added when initializing
ManagedZookeeper. This is needed to ensure reconfig's tests to pass and can be used
in the future for similar needs.

Closes python-zk#477
StephenSorriaux added a commit to StephenSorriaux/kazoo that referenced this issue Oct 1, 2018
Version of Zookeeper is upgraded from 3.5.2-alpha to 3.5.4-beta for automated tests.
Reconfig now needs superuser authentification, a test is added to cover this feature.
Additionnal configuration and jvm parameters can be added when initializing
ManagedZookeeper. This is needed to ensure reconfig's tests to pass and can be used
in the future for similar needs.

Closes python-zk#477
StephenSorriaux added a commit to StephenSorriaux/kazoo that referenced this issue Oct 1, 2018
Version of Zookeeper is upgraded from 3.5.2-alpha to 3.5.4-beta for automated tests.
Reconfig now needs superuser authentification, a test is added to cover this feature.
Additionnal configuration and jvm parameters can be added when initializing
ManagedZookeeper. This is needed to ensure reconfig's tests to pass and can be used
in the future for similar needs.

Closes python-zk#477
StephenSorriaux added a commit to StephenSorriaux/kazoo that referenced this issue Oct 1, 2018
Version of Zookeeper is upgraded from 3.5.2-alpha to 3.5.4-beta for automated tests.
Reconfig now needs superuser authentification, a test is added to cover this feature.
Additionnal configuration and jvm parameters can be added when initializing
ManagedZookeeper. This is needed to ensure reconfig's tests to pass and can be used
in the future for similar needs.

Closes python-zk#477
StephenSorriaux added a commit to StephenSorriaux/kazoo that referenced this issue Oct 8, 2018
Version of Zookeeper is upgraded from 3.5.2-alpha to 3.5.4-beta for automated tests.
Reconfig now needs superuser authentification, a test is added to cover this feature.
Additionnal configuration and jvm parameters can be added when initializing
ManagedZookeeper. This is needed to ensure reconfig's tests to pass and can be used
in the future for similar needs.

Closes python-zk#477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants