Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bedevere no longer comments on PRs that break stable buildbots #333

Closed
tiran opened this issue Jul 9, 2022 · 2 comments · Fixed by #334
Closed

Bedevere no longer comments on PRs that break stable buildbots #333

tiran opened this issue Jul 9, 2022 · 2 comments · Fixed by #334

Comments

@tiran
Copy link
Member

tiran commented Jul 9, 2022

Bedevere used to comment on PRs that break stable buildbots, e.g. python/cpython#17975 (comment) .

It seems like the feature no longer works. For example PR python/cpython#94549 broke four stable WebAssembly buildbots but bedever-bot did not add a warning to the PR.

@Mariatta
Copy link
Member

Mariatta commented Jul 9, 2022

I think there's a different webhook for handling that. Try the https://github.com/python/buildmaster-config/ repo.

@zware zware transferred this issue from python/bedevere Jul 9, 2022
@pablogsal
Copy link
Member

I will fix it when I am back home, but I think the problem is that the regular expression to identify the issue was updated to check for GH- but the commit that was merged had "gh-". We need to add ignorecase after checking that this is indeed the problem.

tiran added a commit to tiran/buildmaster-config that referenced this issue Jul 9, 2022
tiran added a commit to tiran/buildmaster-config that referenced this issue Jul 9, 2022
pablogsal pushed a commit that referenced this issue Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants