Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark NoGIL Linux & MacOS builders as stable #444

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Mark NoGIL Linux & MacOS builders as stable #444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions master/custom/builders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@
("AMD64 RHEL8 Refleaks", "cstratak-RHEL8-x86_64", UnixRefleakBuild),
("AMD64 RHEL8 LTO", "cstratak-RHEL8-x86_64", LTONonDebugUnixBuild),
("AMD64 RHEL8 LTO + PGO", "cstratak-RHEL8-x86_64", LTOPGONonDebugBuild),
("AMD64 Ubuntu NoGIL", "itamaro-ubuntu-aws", UnixNoGilBuild),
("AMD64 Ubuntu NoGIL Refleaks", "itamaro-ubuntu-aws", UnixNoGilRefleakBuild),

# Windows x86-64 MSVC
("AMD64 Windows10", "bolen-windows10", Windows64Build),
Expand All @@ -89,6 +91,7 @@

# macOS x86-64 clang
("x86-64 macOS", "billenstein-macos", UnixBuild),
("x86-64 MacOS Intel NoGIL", "itamaro-macos-intel-aws", UnixNoGilBuild),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If free-threaded CIs are triggered anyway, Can we update this buildbot as refleak checker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik the buildbot test suite is more comprehensive than the equivalent CI test suite (e.g. due to --fast-ci flag for example), so there's value in a buildbot builder with "equivalent configuration". I also believe the release manager considers the buildbot statuses when making release decisions, not GitHub Actions.

I also noticed there are no refleak builders for MacOS at all (for the default build) -- would it be valuable to add such builders? (for default and/or nogil)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik the buildbot test suite is more comprehensive than the equivalent CI test suite

I see!

I also noticed there are no refleak builders for MacOS at all (for the default build) -- would it be valuable to add such builders? (for default and/or nogil)

Oh, I didn't know that :( If possible for me, "yes"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible for me, "yes"

let me keep the existing builders as is (just marked as stable), and I'll look into adding refleak macos builders separately (probably marked "unstable" initially)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also believe the release manager considers the buildbot statuses when making release decisions, not GitHub Actions.

Yes, it's here: https://peps.python.org/pep-0101/#how-to-make-a-release

  • Check the stable buildbots.

    Go to https://buildbot.python.org/all/#/release_status

    Look at the buildbots for the release you’re making. Ignore any that are offline (or inform the community so they can be restarted). If what remains are (mostly) green buildbots, you’re good to go. If you have non-offline red buildbots, you may want to hold up the release until they are fixed. Review the problems and use your judgement, taking into account whether you are making an alpha, beta, or final release.

Although GitHub Actions is kind of implicitly included, because all PRs should be green before merging in the first place.

]


Expand Down Expand Up @@ -133,6 +136,7 @@

# macOS aarch64 clang
("ARM64 macOS", "pablogsal-macos-m1", MacOSArmWithBrewBuild),
("ARM64 MacOS M1 NoGIL", "itamaro-macos-arm64-aws", MacOSArmWithBrewNoGilBuild),
]


Expand Down Expand Up @@ -203,9 +207,6 @@
("AMD64 Fedora Rawhide LTO", "cstratak-fedora-rawhide-x86_64", LTONonDebugUnixBuild),
("AMD64 Fedora Rawhide LTO + PGO", "cstratak-fedora-rawhide-x86_64", LTOPGONonDebugBuild),

("AMD64 Ubuntu NoGIL", "itamaro-ubuntu-aws", UnixNoGilBuild),
("AMD64 Ubuntu NoGIL Refleaks", "itamaro-ubuntu-aws", UnixNoGilRefleakBuild),

("AMD64 Ubuntu", "skumaran-ubuntu-x86_64", UnixBuild),

("AMD64 Arch Linux VintageParser", "pablogsal-arch-x86_64", UnixVintageParserBuild),
Expand All @@ -219,10 +220,6 @@
("AMD64 CentOS9 FIPS Only Blake2 Builtin Hash", "cstratak-CentOS9-fips-x86_64", CentOS9NoBuiltinHashesUnixBuildExceptBlake2),
("AMD64 CentOS9 FIPS No Builtin Hashes", "cstratak-CentOS9-fips-x86_64", CentOS9NoBuiltinHashesUnixBuild),

# MacOS
("x86-64 MacOS Intel NoGIL", "itamaro-macos-intel-aws", UnixNoGilBuild),
("ARM64 MacOS M1 NoGIL", "itamaro-macos-arm64-aws", MacOSArmWithBrewNoGilBuild),

# Windows x86-64 MSVC
("AMD64 Windows Server 2022 NoGIL", "itamaro-win64-srv-22-aws", Windows64NoGilBuild),
]
Expand Down
Loading