Address review

python · May 12, 2023 · 023a615 · 023a615
1 parent e8f6c3d
commit 023a615
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
@@ -6004,17 +6004,16 @@ def test_mutablesequence(self):
         self.assertNotIsInstance((), typing.MutableSequence)
 
     def test_bytestring(self):
-        _typing = import_fresh_module('typing')
         with self.assertWarns(DeprecationWarning):
-            ByteString = _typing.ByteString
+            from typing import ByteString
         with self.assertWarns(DeprecationWarning):
             self.assertIsInstance(b'', ByteString)
         with self.assertWarns(DeprecationWarning):
             self.assertIsInstance(bytearray(b''), ByteString)
         with self.assertWarns(DeprecationWarning):
             class Foo(ByteString): ...
         with self.assertWarns(DeprecationWarning):
-            class Bar(ByteString, _typing.Awaitable): ...
+            class Bar(ByteString, typing.Awaitable): ...
 
     def test_list(self):
         self.assertIsSubclass(list, typing.List)

diff --git a/Lib/typing.py b/Lib/typing.py
@@ -3586,3 +3586,12 @@ def __getattr__(attr):
             )
         return ByteString
     raise AttributeError(f"module 'typing' has no attribute {attr!r}")
+
+
+def _remove_cached_ByteString_from_globals():
+    try:
+        del globals()["ByteString"]
+    except KeyError:
+        pass
+
+_cleanups.append(_remove_cached_ByteString_from_globals)