Skip to content

Commit

Permalink
gh-105539: Fix ResourceWarning from unclosed SQLite connection in tests.
Browse files Browse the repository at this point in the history
Follow up to 1a1bfc2.

Co-authored-by: Erlend E. Aasland <[email protected]>
  • Loading branch information
felixxm and erlend-aasland committed Aug 23, 2023
1 parent 79fdacc commit 02851c2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Lib/test/test_sqlite3/test_backup.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def progress(status, remaining, total):
raise SystemError('nearly out of space')

with self.assertRaises(SystemError) as err:
with sqlite.connect(':memory:') as bck:
with memory_database() as bck:
self.cx.backup(bck, progress=progress)
self.assertEqual(str(err.exception), 'nearly out of space')

Expand Down
6 changes: 3 additions & 3 deletions Lib/test/test_sqlite3/test_dbapi.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
from test.support.os_helper import TESTFN, TESTFN_UNDECODABLE, unlink, temp_dir, FakePath

from .util import memory_database, cx_limit
from .util import MemoryDatabaseMixin


class ModuleTests(unittest.TestCase):
Expand Down Expand Up @@ -1740,10 +1741,9 @@ def test_closed_call(self):
self.check(self.con)


class ClosedCurTests(unittest.TestCase):
class ClosedCurTests(MemoryDatabaseMixin, unittest.TestCase):
def test_closed(self):
con = sqlite.connect(":memory:")
cur = con.cursor()
cur = self.cx.cursor()
cur.close()

for method_name in ("execute", "executemany", "executescript", "fetchall", "fetchmany", "fetchone"):
Expand Down

0 comments on commit 02851c2

Please sign in to comment.