Skip to content

Commit

Permalink
GH-73991: Fix "Operation not supported" on Fedora buildbot. (#121444)
Browse files Browse the repository at this point in the history
Follow-up to #120806. Use `os_helper.skip_unless_xattr` to skip testing
xattr preservation when unsupported.
  • Loading branch information
barneygale authored Jul 7, 2024
1 parent 3bddd07 commit b765e4a
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions Lib/test/test_pathlib/test_pathlib.py
Original file line number Diff line number Diff line change
Expand Up @@ -656,8 +656,6 @@ def test_open_unbuffered(self):
def test_copy_file_preserve_metadata(self):
base = self.cls(self.base)
source = base / 'fileA'
if hasattr(os, 'setxattr'):
os.setxattr(source, b'user.foo', b'42')
if hasattr(os, 'chmod'):
os.chmod(source, stat.S_IRWXU | stat.S_IRWXO)
if hasattr(os, 'chflags') and hasattr(stat, 'UF_NODUMP'):
Expand All @@ -670,12 +668,19 @@ def test_copy_file_preserve_metadata(self):
target_st = target.stat()
self.assertLessEqual(source_st.st_atime, target_st.st_atime)
self.assertLessEqual(source_st.st_mtime, target_st.st_mtime)
if hasattr(os, 'getxattr'):
self.assertEqual(os.getxattr(target, b'user.foo'), b'42')
self.assertEqual(source_st.st_mode, target_st.st_mode)
if hasattr(source_st, 'st_flags'):
self.assertEqual(source_st.st_flags, target_st.st_flags)

@os_helper.skip_unless_xattr
def test_copy_file_preserve_metadata_xattrs(self):
base = self.cls(self.base)
source = base / 'fileA'
os.setxattr(source, b'user.foo', b'42')
target = base / 'copyA'
source.copy(target, preserve_metadata=True)
self.assertEqual(os.getxattr(target, b'user.foo'), b'42')

@needs_symlinks
def test_copy_link_preserve_metadata(self):
base = self.cls(self.base)
Expand Down

0 comments on commit b765e4a

Please sign in to comment.