Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Py_BUILD_CORE_MODULE and Py_BUILD_CORE_MODULE in rotatingtree.c #116181

Closed
aisk opened this issue Mar 1, 2024 · 1 comment
Closed

Remove Py_BUILD_CORE_MODULE and Py_BUILD_CORE_MODULE in rotatingtree.c #116181

aisk opened this issue Mar 1, 2024 · 1 comment
Labels
type-feature A feature request or enhancement

Comments

@aisk
Copy link
Contributor

aisk commented Mar 1, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

Currently, we require Py_Mutex to isolate the states of pseudo random generator in rotatingtree.c, thus the Py_BUILD_CORE_MODULE was introduced in #115301, but we should refrain from using Py_BUILD_CORE_MODULE or Py_BUILD_CORE_BUILTIN to build non-builtin stdlib modules.

Therefore, we should either remove them once Py_Mutex becomes public or explore alternative solutions to address this issue.

Has this already been discussed elsewhere?

Previous discussion: #115301 (comment)

Links to previous discussion of this feature:

No response

Linked PRs
@aisk aisk added the type-feature A feature request or enhancement label Mar 1, 2024
@aisk aisk mentioned this issue Mar 1, 2024
Merged
@ericsnowcurrently
Copy link
Member

nosy @ericsnowcurrently

@aisk aisk changed the title Remove Py_BUILD_CORE_MODULE and in rotatingtree.c` Remove Py_BUILD_CORE_MODULE and Py_BUILD_CORE_MODULE in rotatingtree.c Mar 2, 2024
@bedevere-app bedevere-app bot mentioned this issue Jul 2, 2024
Merged
kumaraditya303 pushed a commit that referenced this issue Jul 3, 2024
@aisk
gh-116181: Remove Py_BUILD_CORE_BUILTIN and Py_BUILD_CORE_MODULE in r…
705a123 
…otatingtree.c (#121260)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 3, 2024
@aisk @miss-islington
pythongh-116181: Remove Py_BUILD_CORE_BUILTIN and Py_BUILD_CORE_MODUL…
99ac75a 
…E in rotatingtree.c (pythonGH-121260)

(cherry picked from commit 705a123)

Co-authored-by: AN Long <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jul 3, 2024
Merged
kumaraditya303 pushed a commit that referenced this issue Jul 3, 2024
@miss-islington @aisk
[3.13] gh-116181: Remove Py_BUILD_CORE_BUILTIN and Py_BUILD_CORE_MODU…
8597149 
…LE in rotatingtree.c (GH-121260) (#121307)

gh-116181: Remove Py_BUILD_CORE_BUILTIN and Py_BUILD_CORE_MODULE in rotatingtree.c (GH-121260)
(cherry picked from commit 705a123)

Co-authored-by: AN Long <[email protected]>
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@aisk @noahbkim
pythongh-116181: Remove Py_BUILD_CORE_BUILTIN and Py_BUILD_CORE_MODUL…
afb0d78 
…E in rotatingtree.c (python#121260)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@aisk @estyxx
pythongh-116181: Remove Py_BUILD_CORE_BUILTIN and Py_BUILD_CORE_MODUL…
afad039 
…E in rotatingtree.c (python#121260)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aisk @ericsnowcurrently @kumaraditya303