Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_imaplib takes 40+ minutes in refleaks builds #120048

Closed
colesbury opened this issue Jun 4, 2024 · 0 comments
Closed

test_imaplib takes 40+ minutes in refleaks builds #120048

colesbury opened this issue Jun 4, 2024 · 0 comments
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@colesbury
Copy link
Contributor

colesbury commented Jun 4, 2024 •
edited by bedevere-app bot
Loading

Bug report

Similar to #120039, test_imaplib has at least one test that expects a timeout and that time out is scaled up with the global time out, so the refleaks tests unnecessarily take 40+ minutes.

cpython/Lib/test/test_imaplib.py

Lines 116 to 117 in 4dcd91c

class SimpleIMAPHandler(socketserver.StreamRequestHandler):
timeout = support.LOOPBACK_TIMEOUT

cpython/Lib/test/test_imaplib.py

Lines 461 to 472 in 4dcd91c

@requires_resource('walltime')
def test_imaplib_timeout_test(self):
_, server = self._setup(SimpleIMAPHandler)
addr = server.server_address[1]
client = self.imap_class("localhost", addr, timeout=None)
self.assertEqual(client.sock.timeout, None)
client.shutdown()
client = self.imap_class("localhost", addr, timeout=support.LOOPBACK_TIMEOUT)
self.assertEqual(client.sock.timeout, support.LOOPBACK_TIMEOUT)
client.shutdown()
with self.assertRaises(ValueError):
client = self.imap_class("localhost", addr, timeout=0)

Linked PRs
@colesbury colesbury added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels Jun 4, 2024
colesbury added a commit to colesbury/cpython that referenced this issue Jun 4, 2024
@colesbury
pythongh-120048: Make test_imaplib faster
5973379 
The `test_imaplib` was taking 40+ minutes in the refleak build bots
because we were using LOOPBACK_TIMEOUT for tests cases that expect to
timeout. LOOPBACK_TIMEOUT scales with the global timeout.

We should use a fixed, very small timeout for cases that we expect to
timeout.
@bedevere-app bedevere-app bot mentioned this issue Jun 4, 2024
Merged
colesbury added a commit that referenced this issue Jun 4, 2024
@colesbury @serhiy-storchaka
gh-120048: Make test_imaplib faster (#120050)
710cbea 
The `test_imaplib` was taking 40+ minutes in the refleak build bots because
the tests waiting on a client `self._setup()` was creating a client that
prevented progress until its connection timed out, which scaled with the
global timeout.

We should set `connect=False` for the tests that don't want `_setup()` to
create a client.

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 4, 2024
@colesbury @serhiy-storchaka @miss-islington
pythongh-120048: Make test_imaplib faster (pythonGH-120050)
2fb0b4d 
The `test_imaplib` was taking 40+ minutes in the refleak build bots because
the tests waiting on a client `self._setup()` was creating a client that
prevented progress until its connection timed out, which scaled with the
global timeout.

We should set `connect=False` for the tests that don't want `_setup()` to
create a client.

(cherry picked from commit 710cbea)

Co-authored-by: Sam Gross <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 4, 2024
@colesbury @serhiy-storchaka @miss-islington
pythongh-120048: Make test_imaplib faster (pythonGH-120050)
acd7afd 
The `test_imaplib` was taking 40+ minutes in the refleak build bots because
the tests waiting on a client `self._setup()` was creating a client that
prevented progress until its connection timed out, which scaled with the
global timeout.

We should set `connect=False` for the tests that don't want `_setup()` to
create a client.

(cherry picked from commit 710cbea)

Co-authored-by: Sam Gross <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
This was referenced Jun 4, 2024
Merged
Merged
colesbury added a commit that referenced this issue Jun 4, 2024
@miss-islington @colesbury @serhiy-storchaka
[3.12] gh-120048: Make test_imaplib faster (GH-120050) (#120070)
210cd98 
The `test_imaplib` was taking 40+ minutes in the refleak build bots because
the tests waiting on a client `self._setup()` was creating a client that
prevented progress until its connection timed out, which scaled with the
global timeout.

We should set `connect=False` for the tests that don't want `_setup()` to
create a client.

(cherry picked from commit 710cbea)

Co-authored-by: Sam Gross <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
colesbury added a commit that referenced this issue Jun 4, 2024
@miss-islington @colesbury @serhiy-storchaka
[3.13] gh-120048: Make test_imaplib faster (GH-120050) (#120069)
a9e807f 
The `test_imaplib` was taking 40+ minutes in the refleak build bots because
the tests waiting on a client `self._setup()` was creating a client that
prevented progress until its connection timed out, which scaled with the
global timeout.

We should set `connect=False` for the tests that don't want `_setup()` to
create a client.

(cherry picked from commit 710cbea)

Co-authored-by: Sam Gross <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
barneygale pushed a commit to barneygale/cpython that referenced this issue Jun 5, 2024
@colesbury @serhiy-storchaka @barneygale
pythongh-120048: Make test_imaplib faster (python#120050)
bde52f1 
The `test_imaplib` was taking 40+ minutes in the refleak build bots because
the tests waiting on a client `self._setup()` was creating a client that
prevented progress until its connection timed out, which scaled with the
global timeout.

We should set `connect=False` for the tests that don't want `_setup()` to
create a client.

Co-authored-by: Serhiy Storchaka <[email protected]>
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@colesbury @serhiy-storchaka @noahbkim
pythongh-120048: Make test_imaplib faster (python#120050)
cfdba73 
The `test_imaplib` was taking 40+ minutes in the refleak build bots because
the tests waiting on a client `self._setup()` was creating a client that
prevented progress until its connection timed out, which scaled with the
global timeout.

We should set `connect=False` for the tests that don't want `_setup()` to
create a client.

Co-authored-by: Serhiy Storchaka <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@colesbury @serhiy-storchaka @estyxx
pythongh-120048: Make test_imaplib faster (python#120050)
7ea4d7f 
The `test_imaplib` was taking 40+ minutes in the refleak build bots because
the tests waiting on a client `self._setup()` was creating a client that
prevented progress until its connection timed out, which scaled with the
global timeout.

We should set `connect=False` for the tests that don't want `_setup()` to
create a client.

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colesbury