Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python fails to build on s390x RHEL7 LTO + PGO 3.x on: #if defined(__APPLE__) && defined(__has_attribute) && __has_attribute(availability) #121199

Closed
vstinner opened this issue Jul 1, 2024 · 2 comments
Closed

Python fails to build on s390x RHEL7 LTO + PGO 3.x on: #if defined(__APPLE__) && defined(__has_attribute) && __has_attribute(availability) #121199

vstinner opened this issue Jul 1, 2024 · 2 comments
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@vstinner
Copy link
Member

vstinner commented Jul 1, 2024 •
edited by bedevere-app bot
Loading

s390x RHEL7 LTO + PGO 3.x: https://buildbot.python.org/all/#/builders/244/builds/7626

./Modules/timemodule.c:1491:70: error: missing binary operator before token "("
 #if defined(__APPLE__) && defined(__has_attribute) && __has_attribute(availability)
                                                                      ^
make[2]: *** [Modules/timemodule.o] Error 1

Linked PRs
@vstinner vstinner added type-bug An unexpected behavior, bug, or error build The build process and cross-build labels Jul 1, 2024
vstinner added a commit to vstinner/cpython that referenced this issue Jul 1, 2024
@vstinner
pythongh-121199: Use _Py__has_attribute() in timemodule.c
4249c09 
Use the _Py__has_attribute() macro in timemodule.c and
bootstrap_hash.c to fix a build error on old GCC versions (GCC 4.8.5
on s390x).
@bedevere-app bedevere-app bot mentioned this issue Jul 1, 2024
Merged
@vstinner
Copy link
Member Author

vstinner commented Jul 1, 2024

vstinner added a commit that referenced this issue Jul 1, 2024
@vstinner
gh-121199: Use _Py__has_attribute() in timemodule.c (#121203)
a0b8b34 
Use the _Py__has_attribute() macro in timemodule.c and
bootstrap_hash.c to fix a build error on old GCC versions (GCC 4.8.5
on s390x).
@vstinner
Copy link
Member Author

vstinner commented Jul 1, 2024

The buildbot is back to green: https://buildbot.python.org/all/#/builders/244

@vstinner vstinner closed this as completed Jul 1, 2024
Akasurde pushed a commit to Akasurde/cpython that referenced this issue Jul 3, 2024
@vstinner @Akasurde
pythongh-121199: Use _Py__has_attribute() in timemodule.c (python#121203
ae955a1 
)

Use the _Py__has_attribute() macro in timemodule.c and
bootstrap_hash.c to fix a build error on old GCC versions (GCC 4.8.5
on s390x).
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@vstinner @noahbkim
pythongh-121199: Use _Py__has_attribute() in timemodule.c (python#121203
3e97b3f 
)

Use the _Py__has_attribute() macro in timemodule.c and
bootstrap_hash.c to fix a build error on old GCC versions (GCC 4.8.5
on s390x).
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@vstinner @estyxx
pythongh-121199: Use _Py__has_attribute() in timemodule.c (python#121203
eef1d9b 
)

Use the _Py__has_attribute() macro in timemodule.c and
bootstrap_hash.c to fix a build error on old GCC versions (GCC 4.8.5
on s390x).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vstinner