Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicated code in compiler's const cache functions #121547

Closed
iritkatriel opened this issue Jul 9, 2024 · 0 comments · Fixed by #121548
Closed

duplicated code in compiler's const cache functions #121547

iritkatriel opened this issue Jul 9, 2024 · 0 comments · Fixed by #121548

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Jul 9, 2024 •
edited by bedevere-app bot
Loading

There is code duplication between _PyCompile_ConstCacheMergeOne and merge_consts_recursive - the former can be implemented in terms of the latter if we add a boolean "is-recursive" arg.

Linked PRs
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Jul 9, 2024
@iritkatriel
pythongh-121547: deduplicate the code of const_cache update functions
79b8e96
@iritkatriel iritkatriel mentioned this issue Jul 9, 2024
Merged
iritkatriel added a commit that referenced this issue Jul 10, 2024
@iritkatriel
gh-121547: deduplicate the code of const_cache update functions (#121548
cced22c 
)
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@iritkatriel @noahbkim
pythongh-121547: deduplicate the code of const_cache update functions (…
f9c11a7 
…python#121548)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@iritkatriel @estyxx
pythongh-121547: deduplicate the code of const_cache update functions (…
a57d4f3 
…python#121548)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-121547: deduplicate the code of const_cache update functions iritkatriel/cpython
1 participant
@iritkatriel