Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove _PyCompile_OpcodeHas* functions #121554

Closed
iritkatriel opened this issue Jul 9, 2024 · 0 comments · Fixed by #121555
Closed

remove _PyCompile_OpcodeHas* functions #121554

iritkatriel opened this issue Jul 9, 2024 · 0 comments · Fixed by #121555

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Jul 9, 2024 •
edited by bedevere-app bot
Loading

There are a bunch of functions in compile.c that expose data from pycore_opcode_metadata.h as private C API. These are only used in Modules/_opcode.c.

However, Modules/_opcode.c can just include pycore_opcode_metadata.h and pycore_opcode_utils.h, and access this data directly.

Linked PRs
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Jul 9, 2024
@iritkatriel
pythongh-121554: remove unnecessary internal functions in compile.c
0c689ba
@iritkatriel iritkatriel mentioned this issue Jul 9, 2024
Merged
iritkatriel added a commit that referenced this issue Jul 10, 2024
@iritkatriel @erlend-aasland
gh-121554: remove unnecessary internal functions in compile.c (#121555)
6557af6 
Co-authored-by: Erlend E. Aasland <[email protected]>
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@iritkatriel @erlend-aasland @noahbkim
pythongh-121554: remove unnecessary internal functions in compile.c (p…
2483331 
…ython#121555)

Co-authored-by: Erlend E. Aasland <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@iritkatriel @erlend-aasland @estyxx
pythongh-121554: remove unnecessary internal functions in compile.c (p…
1041645 
…ython#121555)

Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-121554: remove unnecessary internal functions in compile.c iritkatriel/cpython
1 participant
@iritkatriel