Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace container images to packages from cpython-devcontainers #124612

Closed
2 tasks done
corona10 opened this issue Sep 26, 2024 · 3 comments
Closed
2 tasks done

Replace container images to packages from cpython-devcontainers #124612

corona10 opened this issue Sep 26, 2024 · 3 comments
Assignees
@corona10
Labels
sprint

Comments

@corona10
Copy link
Member

corona10 commented Sep 26, 2024 •
edited by bedevere-app bot
Loading

Now we can manage our own package images at https://github.com/python/cpython-devcontainers and publish them through https://github.com/orgs/python/packages, so it's time to use them.

  • autoconf
  • devcontainer

cc @brettcannon @erlend-aasland

Linked PRs
@corona10 corona10 self-assigned this Sep 26, 2024
corona10 added a commit to corona10/cpython that referenced this issue Sep 26, 2024
@corona10
pythongh-124612: Good bye dockerfile and use GHCR package
f09294f
@bedevere-app bedevere-app bot mentioned this issue Sep 26, 2024
Merged
corona10 added a commit that referenced this issue Sep 26, 2024
@corona10
gh-124612: Good bye dockerfile and use GHCR package (gh-124626)
a4d1fdf
corona10 added a commit to corona10/cpython that referenced this issue Sep 27, 2024
@corona10
pythongh-124612: Use ghcr.io/python/autoconf instead of public image
da25b32
@bedevere-app bedevere-app bot mentioned this issue Sep 27, 2024
Merged
corona10 added a commit that referenced this issue Oct 9, 2024
@corona10
gh-124612: Use ghcr.io/python/autoconf instead of public image (#124657)
b502573 
* gh-124612: Use ghcr.io/python/autoconf instead of public image

* Update
@corona10 corona10 closed this as completed Oct 9, 2024
efimov-mikhail pushed a commit to efimov-mikhail/cpython that referenced this issue Oct 9, 2024
@corona10 @efimov-mikhail
pythongh-124612: Use ghcr.io/python/autoconf instead of public image (p…
7c10a29 
…ython#124657)

* pythongh-124612: Use ghcr.io/python/autoconf instead of public image

* Update
@efimov-mikhail
Copy link
Contributor

@corona10, FYI:

I can't use ``regen-configure.sh``` script "as-is":

-> % Tools/build/regen-configure.sh
+ IMAGE=ghcr.io/python/autoconf:2024.10.06.11200919239
+ AUTORECONF='autoreconf -ivf -Werror'
+ WORK_DIR=/src
+++ dirname Tools/build/regen-configure.sh
++ cd Tools/build/../..
++ pwd
+ abs_srcdir=/home/mikhail.efimov/projects/cpython
+ podman --version
+ docker --version
+ RUNTIME=docker
+ PATH_OPT=
+ command -v selinuxenabled
+ selinuxenabled
+ docker run --rm -v /home/mikhail.efimov/projects/cpython:/src ghcr.io/python/autoconf:2024.10.06.11200919239
Rebuilding configure script using /usr/local/bin/autoconf: This script requires a shell more modern than all
autoreconf: export WARNINGS=error
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force 
autoreconf: configure.ac: tracing
autoreconf: error: /usr/local/bin/autoconf failed with exit status: 1

But this docker command helps me:

-> % docker run --rm -v /home/mikhail.efimov/projects/cpython:/src ghcr.io/python/autoconf:2024.10.06.11200919239 /usr/bin/bash -c "CONFIG_SHELL=/bin/bash  autoreconf -ivf -Werror"
autoreconf: export WARNINGS=error
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force 
autoreconf: configure.ac: tracing
autoreconf: configure.ac: not using Libtool
autoreconf: configure.ac: not using Intltool
autoreconf: configure.ac: not using Gtkdoc
autoreconf: running: /usr/local/bin/autoconf --force
autoreconf: running: /usr/local/bin/autoheader --force
autoreconf: configure.ac: not using Automake
autoreconf: Leaving directory '.'

Maybe you can pass environment value CONFIG_SHELL=/bin/bash to the container?

@corona10
Copy link
Member Author

Would you like to submit the patch to https://github.com/python/cpython-devcontainers ?

@efimov-mikhail
Copy link
Contributor

efimov-mikhail commented Oct 11, 2024 •
edited
Loading

Of course, I will make a PR to this repo.

Edit:
See python/cpython-devcontainers#19

corona10 added a commit to corona10/cpython that referenced this issue Oct 11, 2024
@corona10
pythongh-124612: Update autoconf container image
f18fdf0
@bedevere-app bedevere-app bot mentioned this issue Oct 11, 2024
Merged
corona10 added a commit that referenced this issue Oct 11, 2024
@corona10
gh-124612: Update autoconf container image (#125320)
08f6bf7
@picnixz picnixz mentioned this issue Oct 12, 2024
Closed
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 30, 2024
@corona10 @miss-islington
pythongh-124612: Use ghcr.io/python/autoconf instead of public image (p…
8ea24d0 
…ythonGH-124657)

* pythongh-124612: Use ghcr.io/python/autoconf instead of public image

* Update
(cherry picked from commit b502573)

Co-authored-by: Donghee Na <[email protected]>
@miss-islington miss-islington mentioned this issue Oct 30, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 30, 2024
@corona10 @miss-islington
pythongh-124612: Use ghcr.io/python/autoconf instead of public image (p…
92636fe 
…ythonGH-124657)

* pythongh-124612: Use ghcr.io/python/autoconf instead of public image

* Update
(cherry picked from commit b502573)

Co-authored-by: Donghee Na <[email protected]>
@miss-islington miss-islington mentioned this issue Oct 30, 2024
Merged
erlend-aasland pushed a commit that referenced this issue Oct 30, 2024
@miss-islington @corona10
[3.13] gh-124612: Use ghcr.io/python/autoconf instead of public image (…
d24ea89 
…GH-124657) (#126183)

(cherry picked from commit b502573)

Co-authored-by: Donghee Na <[email protected]>
erlend-aasland pushed a commit that referenced this issue Oct 30, 2024
@miss-islington @corona10
[3.12] gh-124612: Use ghcr.io/python/autoconf instead of public image (…
679dfae 
…GH-124657) (#126184)

(cherry picked from commit b502573)

Co-authored-by: Donghee Na <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corona10 corona10

Labels
sprint
Projects
Sprint 2024
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corona10 @efimov-mikhail