Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require reviews for new features #126081

Open
ambv opened this issue Oct 28, 2024 · 5 comments
Open

Require reviews for new features #126081

ambv opened this issue Oct 28, 2024 · 5 comments
Labels
type-feature A feature request or enhancement

Comments

@ambv
Copy link
Contributor

ambv commented Oct 28, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Announcement:
https://discuss.python.org/t/workflow-change-coming-mandatory-reviews-on-new-features/68135

Linked PRs
@ambv ambv added the type-feature A feature request or enhancement label Oct 28, 2024
ambv added a commit to ambv/cpython that referenced this issue Oct 28, 2024
@ambv
pythongh-126081: For PRs labeled with "type-feature", require a core …
0e7ff33 
…review
@bedevere-app bedevere-app bot mentioned this issue Oct 28, 2024
Merged
ambv added a commit that referenced this issue Oct 28, 2024
@ambv @hugovk
gh-126081: For PRs labeled with "type-feature", require a core review (…
ced2691 
…GH-126082)

Co-authored-by: Hugo van Kemenade <[email protected]>
@picnixz
Copy link
Contributor

picnixz commented Oct 28, 2024

@ambv Can this one be closed or do you want to test more things?

@gaogaotiantian
Copy link
Member

I have a question about the logistics. Normally we tag type-feature on the issue, not the PR right?

@nineteendo
Copy link
Contributor

The label is derived from the issue:

To ensure this label gets applied, Bedevere will be updated to do the following:

  • if we open a PR,
  • and that PR touches code (i.e. not only docs / tests / build / CI configuration),
  • there is an issue linked to the PR,
  • and that issue is not marked with a type-bug, type-crash, or type-security label,
  • then Bedevere will mark this PR with the type-feature label.

@gaogaotiantian
Copy link
Member

That makes sense, thanks!

@ambv
Copy link
Contributor Author

ambv commented Oct 29, 2024

The rollout will take two more weeks for the label to be automatically applied. Please see the Discourse topic for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ambv @picnixz @gaogaotiantian @nineteendo