Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestProgram is mentioned in the unittest docs but is not documented #64308

Closed
bitdancer opened this issue Jan 2, 2014 · 4 comments · Fixed by #121675
Closed

TestProgram is mentioned in the unittest docs but is not documented #64308

bitdancer opened this issue Jan 2, 2014 · 4 comments · Fixed by #121675
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes docs Documentation in the Doc dir easy type-feature A feature request or enhancement

Comments

@bitdancer
Copy link
Member

bitdancer commented Jan 2, 2014

BPO 20109
Nosy @brettcannon, @ezio-melotti, @bitdancer, @voidspace

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2014-01-02.18:01:47.665>
labels = ['easy', '3.9', '3.10', '3.11', 'type-feature', 'docs']
title = 'TestProgram is mentioned in the unittest docs but is not documented'
updated_at = <Date 2021-06-22.22:48:08.205>
user = 'https://github.com/bitdancer'

bugs.python.org fields:

activity = <Date 2021-06-22.22:48:08.205>
actor = 'brett.cannon'
assignee = 'docs@python'
closed = False
closed_date = None
closer = None
components = ['Documentation']
creation = <Date 2014-01-02.18:01:47.665>
creator = 'r.david.murray'
dependencies = []
files = []
hgrepos = []
issue_num = 20109
keywords = ['easy']
message_count = 3.0
messages = ['207178', '259728', '259831']
nosy_count = 6.0
nosy_names = ['brett.cannon', 'ezio.melotti', 'r.david.murray', 'michael.foord', 'docs@python', 'beng94']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue20109'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

Linked PRs

@bitdancer
Copy link
Member Author

IMO, TestProgram should either be made anonymous in the docs ('main returns an object that has a results attribute...') or its external API should be formally documented. If results is the only external API other than its init (which is documented as unittest.main), then I would suggest the former. In either case exactly what 'results' contains should be clarified.

@bitdancer bitdancer added the docs Documentation in the Doc dir label Jan 2, 2014
@ezio-melotti ezio-melotti added the type-feature A feature request or enhancement label Feb 15, 2014
@beng94
Copy link
Mannequin

beng94 mannequin commented Feb 6, 2016

I think TestProgram should be anonymous, all the work is done in its constructor. I don't see why would anyone would call its functions. I can update the docs if it's needed.

@voidspace
Copy link
Contributor

TestProgram is an abomination, but it has been publicly exposed in unittest since forever.

@iritkatriel iritkatriel added easy 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes labels Jun 21, 2021
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
@stinovlas
Copy link
Contributor

I'm working on this during EuroPython 2024 sprint. I'll anonymize TestProgram in the docs.

stinovlas added a commit to stinovlas/cpython that referenced this issue Jul 13, 2024
stinovlas added a commit to stinovlas/cpython that referenced this issue Jul 13, 2024
stinovlas added a commit to stinovlas/cpython that referenced this issue Jul 13, 2024
stinovlas added a commit to stinovlas/cpython that referenced this issue Jul 13, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 14, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 14, 2024
encukou pushed a commit that referenced this issue Jul 14, 2024
encukou pushed a commit that referenced this issue Jul 18, 2024
GH-121743)

gh-64308: Remove TestProgram from the unittest docs (GH-121675)
(cherry picked from commit f6f4022)

Co-authored-by: Jan Musílek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes docs Documentation in the Doc dir easy type-feature A feature request or enhancement
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants