Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument Clinic: when cloning functions with path_t, path_t retains the old name #64631

Closed
larryhastings opened this issue Jan 29, 2014 · 3 comments · Fixed by #104167
Closed
Assignees
Labels
topic-argument-clinic type-bug An unexpected behavior, bug, or error

Comments

@larryhastings
Copy link
Contributor

larryhastings commented Jan 29, 2014

BPO 20432
Nosy @larryhastings

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/larryhastings'
closed_at = None
created_at = <Date 2014-01-29.05:26:03.504>
labels = ['type-bug', 'expert-argument-clinic']
title = 'Argument Clinic: when cloning functions with path_t, path_t retains the old name'
updated_at = <Date 2015-02-25.15:25:49.080>
user = 'https://github.com/larryhastings'

bugs.python.org fields:

activity = <Date 2015-02-25.15:25:49.080>
actor = 'serhiy.storchaka'
assignee = 'larry'
closed = False
closed_date = None
closer = None
components = ['Argument Clinic']
creation = <Date 2014-01-29.05:26:03.504>
creator = 'larry'
dependencies = []
files = []
hgrepos = []
issue_num = 20432
keywords = []
message_count = 1.0
messages = ['209615']
nosy_count = 1.0
nosy_names = ['larry']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue20432'
versions = ['Python 3.4']

Linked PRs

@larryhastings
Copy link
Contributor Author

If you have:

module.f1
   path: path_t

...
    module.f2 = module.f1

Then the initializer for "path" in module_f2 will supply "f1" as the function name for error messages.

@larryhastings larryhastings self-assigned this Jan 29, 2014
@larryhastings larryhastings added the type-bug An unexpected behavior, bug, or error label Jan 29, 2014
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
@erlend-aasland
Copy link
Contributor

It seems like this was fixed somewhere between now and January 2014. I added some tests that should cover these cases in gh-104167.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented May 5, 2023

Tests added, marking as resolved with:

carljm added a commit to carljm/cpython that referenced this issue May 5, 2023
* main: (61 commits)
  pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)
  pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)
  pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)
  pythongh-64658: Expand Argument Clinic return converter docs (python#104175)
  pythonGH-103092: port `_asyncio` freelist to module state (python#104196)
  pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
  pythongh-104190: fix ubsan crash (python#104191)
  pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)
  pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)
  pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)
  pythongh-68968: Correcting message display issue with assertEqual (python#103937)
  pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)
  pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)
  pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)
  pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)
  pythongh-91896: Deprecate collections.abc.ByteString (python#102096)
  pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)
  pythongh-102500: Document PEP 688 (python#102571)
  pythongh-102500: Implement PEP 688 (python#102521)
  pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)
  ...
jbower-fb pushed a commit to jbower-fb/cpython-jbowerfb that referenced this issue May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-argument-clinic type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants