Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeit accepts -c/--clock and -t/--time without any functionality #90085

Closed
malemburg opened this issue Nov 29, 2021 · 2 comments
Closed

timeit accepts -c/--clock and -t/--time without any functionality #90085

malemburg opened this issue Nov 29, 2021 · 2 comments
Labels
3.10 only security fixes 3.11 only security fixes stdlib Python modules in the Lib dir

Comments

@malemburg
Copy link
Member

BPO 45927
Nosy @malemburg

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2021-11-29.14:15:45.584>
labels = ['library', '3.10', '3.11']
title = 'timeit accepts -c/--clock and -t/--time without any functionality'
updated_at = <Date 2021-11-29.14:15:45.584>
user = 'https://github.com/malemburg'

bugs.python.org fields:

activity = <Date 2021-11-29.14:15:45.584>
actor = 'lemburg'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2021-11-29.14:15:45.584>
creator = 'lemburg'
dependencies = []
files = []
hgrepos = []
issue_num = 45927
keywords = []
message_count = 1.0
messages = ['407276']
nosy_count = 1.0
nosy_names = ['lemburg']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue45927'
versions = ['Python 3.10', 'Python 3.11']

@malemburg
Copy link
Member Author

From the code:

    opts, args = getopt.getopt(args, "n:u:s:r:tcpvh",
                               ["number=", "setup=", "repeat=",
                                "time", "clock", "process",
                                "verbose", "unit=", "help"])

but the options -c and -t are not used in the subsequent code.

This can lead to situations where if you mistype e.g. -s as -c, you get completely wrong results (see https://bugs.python.org/issue45902 for an example).

@malemburg malemburg added 3.10 only security fixes 3.11 only security fixes stdlib Python modules in the Lib dir labels Nov 29, 2021
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
hauntsaninja added a commit to hauntsaninja/cpython that referenced this issue Jul 17, 2022
See bpo-28240. The functionality was removed in 3d7feb9.
The options had been deprecated since Python 3.3
JelleZijlstra pushed a commit that referenced this issue Oct 7, 2022
See bpo-28240. The functionality was removed in 3d7feb9.
The options had been deprecated since Python 3.3
@JelleZijlstra
Copy link
Member

Thanks for the fix @hauntsaninja!

carljm added a commit to carljm/cpython that referenced this issue Oct 8, 2022
* main: (38 commits)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  pythonGH-83901: Improve Signature.bind error message for missing keyword-only params (python#95347)
  pythongh-61105: Add default param, note on using cookiejar subclass (python#95427)
  pythongh-96288: Add a sentence to `os.mkdir`'s docstring. (python#96271)
  pythongh-96073: fix backticks in NEWS entry (pythonGH-98056)
  pythongh-92886: [clinic.py] raise exception on invalid input instead of assertion (pythonGH-98051)
  pythongh-97997: Add col_offset field to tokenizer and use that for AST nodes (python#98000)
  pythonGH-88968: Reject socket that is already used as a transport (python#98010)
  pythongh-96346: Use double caching for re._compile() (python#96347)
  pythongh-91708: Revert params note in urllib.parse.urlparse table (python#96699)
  pythongh-96265: Fix some formatting in faq/design.rst (python#96924)
  pythongh-73196: Add namespace/scope clarification for inheritance section (python#92840)
  pythongh-97646: Change `.js` and `.mjs` files mimetype to conform to RFC 9239 (python#97934)
  pythongh-97923: Always run Ubuntu SSL tests with others in CI (python#97940)
  pythongh-97956: Mention `generate_global_objects.py` in `AC How-To` (python#97957)
  pythongh-96959: Update HTTP links which are redirected to HTTPS (python#98039)
  ...
carljm added a commit to carljm/cpython that referenced this issue Oct 9, 2022
* main: (5519 commits)
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
  pythongh-68686: Retire eptag ptag scripts (python#98064)
  pythongh-97922: Run the GC only on eval breaker (python#97920)
  GitHub Workflows security hardening (python#96492)
  Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)
  pythongh-97913 Docs: Add walrus operator to the index (python#97921)
  [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)
  pythongh-97822: Fix http.server documentation reference to test() function (python#98027)
  pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)
  pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)
  pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  ...
mpage pushed a commit to mpage/cpython that referenced this issue Oct 11, 2022
See bpo-28240. The functionality was removed in 3d7feb9.
The options had been deprecated since Python 3.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.10 only security fixes 3.11 only security fixes stdlib Python modules in the Lib dir
Projects
None yet
Development

No branches or pull requests

2 participants