Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100174: [Enum] Correct PowersOfThree example. #100178

Merged
merged 1 commit into from
Dec 11, 2022
Merged

gh-100174: [Enum] Correct PowersOfThree example. #100178

merged 1 commit into from
Dec 11, 2022

Conversation

Beweeted
Copy link
Contributor

@Beweeted Beweeted commented Dec 11, 2022 •
edited by bedevere-bot
Loading

Changed from multiples of 3 to powers of 3 to match the class name.

@Beweeted
[3.11] gh-100174: Fix math in PowersOfThree example class.
660d462 
Changed from multiples of 3 to powers of 3 to match the class name.
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Dec 11, 2022 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot mentioned this pull request Dec 11, 2022
Closed
@netlify
Copy link

netlify bot commented Dec 11, 2022 •
edited
Loading

✅ Deploy Preview for python-cpython-preview ready!

Name Link
🔨 Latest commit 660d462
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/63964cf6ac4fe9000810997b
😎 Deploy Preview https://deploy-preview-100178--python-cpython-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 11, 2022
@AlexWaygood
Copy link
Member

Thanks! Unfortunately, nearly all Python PRs are made against the main branch, and then backported to maintenance branches after they've been merged. The best thing to do is to recreate the PR based against main.

@Beweeted
Copy link
Contributor Author

This is against main. I'm sure I missed something, but I couldn't find the button to make a new branch from the docs. I hit edit on the file, and it auto-forked it and gave me the option to merge it back in.

If you can point me in the right direction @AlexWaygood I'm happy to do the extra steps. Unless those steps are to sync & build the whole repo on my local, which is what the cpython docs were telling me to do.

Really, the most confusing thing is talking about backporting. Which I don't understand how that's applicable to this at all.

@AlexWaygood AlexWaygood reopened this Dec 11, 2022
@AlexWaygood
Copy link
Member

AlexWaygood commented Dec 11, 2022 •
edited
Loading

This is against main. I'm sure I missed something, but I couldn't find the button to make a new branch from the docs. I hit edit on the file, and it auto-forked it and gave me the option to merge it back in.

If you can point me in the right direction @AlexWaygood I'm happy to do the extra steps. Unless those steps are to sync & build the whole repo on my local, which is what the cpython docs were telling me to do.

Really, the most confusing thing is talking about backporting. Which I don't understand how that's applicable to this at all.

Apologies! Your PR title confused me. We usually use the [3.11] tag for PRs that are against the 3.11 branch.

The "backport" PR will be done automatically by a robot after this PR is merged. You won't need to worry about it.

@AlexWaygood AlexWaygood changed the title [3.11] gh-100174: Fix math in PowersOfThree example class. [gh-100174: Fix math in PowersOfThree example class. Dec 11, 2022
@AlexWaygood AlexWaygood changed the title [gh-100174: Fix math in PowersOfThree example class. gh-100174: Fix math in PowersOfThree example class. Dec 11, 2022
@AlexWaygood
Copy link
Member

We will need you to sign the CLA, however :)

@AlexWaygood AlexWaygood added the needs backport to 3.11 only security fixes label Dec 11, 2022
@Beweeted
Copy link
Contributor Author

Oh, oh oh. That makes sense. I had been seeing the other PRs and most seemed to have the version in the name. It wasn't mentioned in the comment, but I thought I was being a keener. I'll keep this in mind next time!

@ethanfurman ethanfurman changed the title gh-100174: Fix math in PowersOfThree example class. gh-100174: [Enum] Correct PowersOfThree example. Dec 11, 2022
@ethanfurman ethanfurman self-assigned this Dec 11, 2022
ethanfurman
ethanfurman approved these changes Dec 11, 2022
View reviewed changes
Copy link
Member

@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As soon as you sign the CLA we can merge this in.

@ethanfurman ethanfurman merged commit 868bab0 into python:main Dec 11, 2022
@miss-islington
Copy link
Contributor

Thanks @Beweeted for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-100181 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 11, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2022
@Beweeted @miss-islington
pythongh-100174: [Enum] Correct PowersOfThree example. (pythonGH-100178)
4ce43b5 
Changed from multiples of 3 to powers of 3 to match the class name.
(cherry picked from commit 868bab0)

Co-authored-by: Beweeted <[email protected]>
miss-islington added a commit that referenced this pull request Dec 11, 2022
@miss-islington @Beweeted
gh-100174: [Enum] Correct PowersOfThree example. (GH-100178)
593c5a0 
Changed from multiples of 3 to powers of 3 to match the class name.
(cherry picked from commit 868bab0)

Co-authored-by: Beweeted <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Dec 14, 2022
@carljm
Merge branch 'main' into typedocs
53d33a1 
* main: (103 commits)
  pythongh-100248: Add missing `ssl_shutdown_timeout` parameter in `asyncio` docs (python#100249)
  Assorted minor fixes for specialization stats. (pythonGH-100219)
  pythongh-100176: venv: Remove redundant compat code for Python <= 3.2 (python#100177)
  pythonGH-100222: Redefine _Py_CODEUNIT as a union to clarify structure of code unit. (pythonGH-100223)
  pythongh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer warning) (python#100215)
  pythonGH-100206: use versionadded for the addition of sysconfig.get_default_scheme (python#100207)
  pythongh-81057: Move _Py_RefTotal to the "Ignored Globals" List (pythongh-100203)
  pythongh-81057: Move Signal-Related Globals to _PyRuntimeState (pythongh-100085)
  pythongh-81057: Move faulthandler Globals to _PyRuntimeState (pythongh-100152)
  pythongh-81057: Move tracemalloc Globals to _PyRuntimeState (pythongh-100151)
  pythonGH-100143: Improve collecting pystats for parts of runs (pythonGH-100144)
  pythongh-99955: standardize return values of functions in compiler's code-gen (python#100010)
  pythongh-79218: Define `MS_WIN64` macro for Mingw-w64 64bit on Windows (pythonGH-100137)
  Fix: typo (Indention) (pythonGH-99904)
  pythongh-96715 Remove redundant NULL check in `profile_trampoline` function (python#96716)
  pythongh-100176: remove incorrect version compatibility check from argument clinic (python#100190)
  clarify the 4300-digit limit on int-str conversion (python#100175)
  pythongh-70393: Clarify mention of "middle" scope (python#98839)
  pythongh-99688: Fix outdated tests in test_unary (python#99712)
  pythongh-100174: [Enum] Correct PowersOfThree example. (pythonGH-100178)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

Assignees

@ethanfurman ethanfurman

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Beweeted @AlexWaygood @miss-islington @bedevere-bot @ethanfurman