[3.6] bpo-34272: Restore test_capi.EmbeddingTests, unintentionally removed in 278d975c #10078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordmauve
changed the title
vstinner
changed the title
|
Rather than adding back tests to test_capi.py, maybe it would be better to create Lib/test/test_embed.py to be closer to 3.7 and master branches, to ease future backports. What do you think @serhiy-storchaka? cc @ncoghlan @ericsnowcurrently |
|
I'm OK with the idea of backporting the refactoring, but I think it would be good to restore the test case in the original location first, so commit moving it is clearer. |
serhiy-storchaka
approved these changes
Oct 30, 2018
|
Thank you for catching this @lordmauve! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe some tests were unintentionally dropped from the
3.6branch in 278d975 as a result of a cherry-pick from 8f7bb10 by @serhiy-storchaka.In
master, EmbeddingTests has moved toLib/test/test_embed.py, so I think the cherry-pick may have seen this as a removal and applied it to the 3.6 branch. It was sandwiched between two other classes that were removed intentionally so perhaps git saw it as one hunk?This PR restores the missing test case to the 3.6 branch.
https://bugs.python.org/issue34272