-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-97930: Apply changes from importlib_resources 5.12. #102010
Conversation
jaraco
commented
Feb 18, 2023
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: Refresh importlib.resources #97930
Those test failures are interesting. They certainly seem related to the changes. But that doesn't explain why the tests pass for me locally or why they pass in importlib_resources. I'll continue to investigate. |
db3a1dd
to
4d92e56
Compare
Aah. The issue was that new files were added but not included in the commit (the usual foot gun aka git). I probably wouldn't have encountered that error had I been using jj. |
4d92e56
to
0660828
Compare
The remaining test is failing for unrelated reasons. Merging. Thanks for the review! |
|
|
|
|
I suspect the buildbot failures are due to missing directory declarations. Will investigate. |