Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in code comment #102726

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Fix typo in code comment #102726

merged 2 commits into from
Mar 15, 2023

Conversation

martin-martin
Copy link
Contributor

@martin-martin martin-martin commented Mar 15, 2023

I just came across a tiny typo while doing research for an article and thought I'd note it via a PR in case it's considered worth updating. :)

Thanks for all your work!

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Mar 15, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Mar 15, 2023
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@martin-martin
Copy link
Contributor Author

Oh, I thought that a rebase would be a good idea in this situation, as there were some other merged changes before the checks here were complete.

But it looks like a test is failing now? I'm not sure why this would happen considering I rebased on main and the only change is a typo fix in a code comment.

Apologies, I didn't mean to take up too much of anyones' time with this 😬

@AlexWaygood
Copy link
Member

The failing test will be fixed by #102735; after that's merged, we can merge main into your branch here, and then the test will pass here and we can merge this in :)

@martin-martin
Copy link
Contributor Author

Thank you @AlexWaygood :)

@AlexWaygood AlexWaygood merged commit 00d1ef7 into python:main Mar 15, 2023
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants