Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-87868: Sort and remove duplicates in getenvironment() #102731

Merged
merged 63 commits into from
Jan 9, 2024
Merged

gh-87868: Sort and remove duplicates in getenvironment() #102731

merged 63 commits into from
Jan 9, 2024

Commits on Mar 15, 2023

  1. pythongh-87868: correctly sort and remove duplicates in getenvironment()

    @aisk
    aisk committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    aed39b7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into getenvironment

    @AlexWaygood
    AlexWaygood authored Mar 15, 2023
    Configuration menu
    Copy the full SHA
    4de761b View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. check null in normalize_environment

    @aisk
    aisk committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    04f7d59 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. Update Modules/_winapi.c 

    Co-authored-by: Pieter Eendebak <[email protected]>
    @aisk @eendebakpt
    aisk and eendebakpt authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    c43abb2 View commit details
    Browse the repository at this point in the history

  2. Update Modules/_winapi.c 

    Co-authored-by: Pieter Eendebak <[email protected]>
    @aisk @eendebakpt
    aisk and eendebakpt authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    3f6319a View commit details
    Browse the repository at this point in the history

  3. Update Lib/test/test_subprocess.py 

    Co-authored-by: Pieter Eendebak <[email protected]>
    @aisk @eendebakpt
    aisk and eendebakpt authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    8ef3b9c View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into getenvironment

    @aisk
    aisk committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    46491c5 View commit details
    Browse the repository at this point in the history

  5. Adapt latest changes from main branch

    @aisk
    aisk committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    ca13205 View commit details
    Browse the repository at this point in the history

  6. Fix test case

    @aisk
    aisk committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    f727004 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. update for review comments

    @aisk
    aisk committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    6b9e873 View commit details
    Browse the repository at this point in the history

  2. add win32 related env validation tests

    @aisk
    aisk committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    dd53528 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. fix memory leak

    @aisk
    aisk committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    37fa2f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Merge branch 'main' into getenvironment

    @aisk
    aisk authored Sep 6, 2023
    Configuration menu
    Copy the full SHA
    fcd8b88 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Merge branch 'main' into getenvironment

    @aisk
    aisk authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    96754a1 View commit details
    Browse the repository at this point in the history

  2. follow PEP7

    @aisk
    aisk committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    47155b5 View commit details
    Browse the repository at this point in the history

  3. add error check

    @aisk
    aisk committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    a204740 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. fix test

    @aisk
    aisk committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    8ca7b8e View commit details
    Browse the repository at this point in the history

  2. better cleanup in error path

    @aisk
    aisk committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    b620bdb View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. fix a mem leak

    @aisk
    aisk committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    65c8483 View commit details
    Browse the repository at this point in the history

  2. refactor error handling

    @aisk
    aisk committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    2d2fd4d View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. fix one off iteration and add test

    @aisk
    aisk committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    2096209 View commit details
    Browse the repository at this point in the history

  2. fix one env test on non windows platforms

    @aisk
    aisk committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    da55b3b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2023

  1. Merge branch 'main' into getenvironment

    @aisk
    aisk authored Sep 24, 2023
    Configuration menu
    Copy the full SHA
    5b17740 View commit details
    Browse the repository at this point in the history

  2. using vector call

    @aisk
    aisk committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    bf5a555 View commit details
    Browse the repository at this point in the history

  3. fix test on none windows platforms

    @aisk
    aisk committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    66fddbe View commit details
    Browse the repository at this point in the history

  4. fix typo in test

    @aisk
    aisk committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    2b82368 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. fix test on linux

    @aisk
    aisk committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    5c581ea View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. revert line end modify and align codes with pep7

    @aisk
    aisk committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    6b5d1da View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. Update Modules/_winapi.c 

    Co-authored-by: Steve Dower <[email protected]>
    @aisk @zooba
    aisk and zooba authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    bcd8910 View commit details
    Browse the repository at this point in the history

  2. Update Modules/_winapi.c 

    Co-authored-by: Steve Dower <[email protected]>
    @aisk @zooba
    aisk and zooba authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    3423e13 View commit details
    Browse the repository at this point in the history

  3. Update Modules/_winapi.c 

    Co-authored-by: Steve Dower <[email protected]>
    @aisk @zooba
    aisk and zooba authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    03a4f7e View commit details
    Browse the repository at this point in the history

  4. Update Modules/_winapi.c 

    Co-authored-by: Steve Dower <[email protected]>
    @aisk @zooba
    aisk and zooba authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    186d718 View commit details
    Browse the repository at this point in the history

  5. Update Modules/_winapi.c 

    Co-authored-by: Steve Dower <[email protected]>
    @aisk @zooba
    aisk and zooba authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    8b074df View commit details
    Browse the repository at this point in the history

  6. Update Modules/_winapi.c 

    Co-authored-by: Steve Dower <[email protected]>
    @aisk @zooba
    aisk and zooba authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    b675260 View commit details
    Browse the repository at this point in the history

  7. Update Modules/_winapi.c 

    Co-authored-by: Steve Dower <[email protected]>
    @aisk @zooba
    aisk and zooba authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    fb93eb1 View commit details
    Browse the repository at this point in the history

  8. Update Modules/_winapi.c 

    Co-authored-by: Steve Dower <[email protected]>
    @aisk @zooba
    aisk and zooba authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    f9d97eb View commit details
    Browse the repository at this point in the history

  9. Update Modules/_winapi.c 

    Co-authored-by: Steve Dower <[email protected]>
    @aisk @zooba
    aisk and zooba authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    6f3b7ce View commit details
    Browse the repository at this point in the history

  10. Update Modules/_winapi.c 

    Co-authored-by: Steve Dower <[email protected]>
    @aisk @zooba
    aisk and zooba authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    b9b8d6e View commit details
    Browse the repository at this point in the history

  11. Update Modules/_winapi.c 

    Co-authored-by: Steve Dower <[email protected]>
    @aisk @zooba
    aisk and zooba authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    5fd7ebf View commit details
    Browse the repository at this point in the history

  12. Update Modules/_winapi.c 

    Co-authored-by: Steve Dower <[email protected]>
    @aisk @zooba
    aisk and zooba authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    f87970a View commit details
    Browse the repository at this point in the history

  13. Update Lib/test/test_subprocess.py 

    Co-authored-by: Steve Dower <[email protected]>
    @aisk @zooba
    aisk and zooba authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    cbdfa84 View commit details
    Browse the repository at this point in the history

  14. only keep the last duplicated environment key

    @aisk
    aisk committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    8748103 View commit details
    Browse the repository at this point in the history

  15. split the normalize_environment function into two

    @aisk
    aisk committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    4aff3b4 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2024

  1. Update Lib/test/test_subprocess.py 

    Co-authored-by: Pieter Eendebak <[email protected]>
    @aisk @eendebakpt
    aisk and eendebakpt authored Jan 7, 2024
    Configuration menu
    Copy the full SHA
    67b8731 View commit details
    Browse the repository at this point in the history

  2. remove the error check for PyList_GET_ITEM

    @aisk
    aisk committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    d02319e View commit details
    Browse the repository at this point in the history

  3. decref the vectorcall result

    @aisk
    aisk committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    d1c794b View commit details
    Browse the repository at this point in the history

  4. split normalze_keys into sort_keys and dedup_keys

    @aisk
    aisk committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    1763421 View commit details
    Browse the repository at this point in the history

  5. Update Modules/_winapi.c 

    Co-authored-by: Erlend E. Aasland <[email protected]>
    @aisk @erlend-aasland
    aisk and erlend-aasland authored Jan 7, 2024
    Configuration menu
    Copy the full SHA
    dbbaf1b View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. refactor sort_environment_keys to remove the goto error stuff

    @aisk
    aisk committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    176e90d View commit details
    Browse the repository at this point in the history

  2. refactor the dedup_environment_keys to get rid of the goto error stuff

    @aisk
    aisk committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    d088083 View commit details
    Browse the repository at this point in the history

  3. fix a memory leak in normalize_environment

    @aisk
    aisk committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    471c8b8 View commit details
    Browse the repository at this point in the history

  4. revert the commit that moves key validation codes to the original place

    @aisk
    aisk committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a2dab93 View commit details
    Browse the repository at this point in the history

  5. fixed a memory leak

    @aisk
    aisk committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    6a2bbee View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Update Modules/_winapi.c 

    Co-authored-by: Steve Dower <[email protected]>
    @aisk @zooba
    aisk and zooba authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    22548cc View commit details
    Browse the repository at this point in the history

  2. Update Modules/_winapi.c 

    Co-authored-by: Steve Dower <[email protected]>
    @aisk @zooba
    aisk and zooba authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    63cf753 View commit details
    Browse the repository at this point in the history

  3. using int as return value rather than bool

    @aisk
    aisk committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    91d091d View commit details
    Browse the repository at this point in the history

  4. get rid of the goto error in normalize_environment

    @aisk
    aisk committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    b053e2a View commit details
    Browse the repository at this point in the history

  5. Update Misc/NEWS.d/next/Windows/2023-03-15-23-53-45.gh-issue-87868.4C… 

    …36oQ.rst

Co-authored-by: Erlend E. Aasland <[email protected]>
    @aisk @erlend-aasland
    aisk and erlend-aasland authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    5dd6215 View commit details
    Browse the repository at this point in the history

  6. Update Modules/_winapi.c 

    Co-authored-by: Erlend E. Aasland <[email protected]>
    @aisk @erlend-aasland
    aisk and erlend-aasland authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    be49dae View commit details
    Browse the repository at this point in the history

  7. Update Modules/_winapi.c 

    Co-authored-by: Erlend E. Aasland <[email protected]>
    @aisk @erlend-aasland
    aisk and erlend-aasland authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    0aff1e9 View commit details
    Browse the repository at this point in the history

  8. Update Modules/_winapi.c 

    Co-authored-by: Erlend E. Aasland <[email protected]>
    @aisk @erlend-aasland
    aisk and erlend-aasland authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    72fc36d View commit details
    Browse the repository at this point in the history

  9. Update Modules/_winapi.c 

    Co-authored-by: Erlend E. Aasland <[email protected]>
    @aisk @erlend-aasland
    aisk and erlend-aasland authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    725baec View commit details
    Browse the repository at this point in the history

  10. Update Modules/_winapi.c 

    Co-authored-by: Erlend E. Aasland <[email protected]>
    @aisk @erlend-aasland
    aisk and erlend-aasland authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    0a308be View commit details
    Browse the repository at this point in the history