gh-83004: Harden msvcrt init #103383
Merged
gh-83004: Harden msvcrt init #103383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erlend-aasland
commented
Apr 8, 2023
•
erlend-aasland
commented
- Issue: Improve stdlib module initialization error handling. #83004
kumaraditya303
approved these changes
Apr 10, 2023
|
Darn, I forgot to add error handling for |
zooba
reviewed
Apr 11, 2023
Comment on lines
+673
to
+676
| if (version == NULL) { | ||
| goto error; | ||
| } | ||
| st = PyModule_AddObjectRef(m, "CRT_ASSEMBLY_VERSION", version); |
There was a problem hiding this comment.
@erlend-aasland Just FYI, the modsupport functions allow passing in NULL provided an error has already occurred, and they just let it chain. So the code here was fine before.
No need to revert now though.
There was a problem hiding this comment.
TIL! Sorry for not waiting on your review.
There was a problem hiding this comment.
However, there was a leak if PyModule_AddObject failed, since that API only eat refs if successful.
There was a problem hiding this comment.
Sorry I should have been more careful in this.
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.