Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-82054: Implements test.regrtest unittest sharding to pull in long tails for asyncio #103852

Closed
wants to merge 1 commit into from

Conversation

zitterbewegung
Copy link
Contributor

gh-82054: Implements test.regrtest unittest sharding to pull in long tails for asyncio and compiler

TLDR: This runs test_asyncio and test_compiler sub-tests in parallel

Below is a summary about this change which is the same information from the issue in cinder that addressed this. It can be found at facebookincubator/cinder@3c6be01

Summary:

These two tests are typically the long-poles in runs because they are modules with a lot of further sub-tests run serially. By breaking out the sub-tests as independent modules we can run a lot more in parallel.

The real win comes in the next diff but with this change alone on my devserver:

  • With a debug build:
    • time make testcinder goes from ~25m -> ~19m.
    • time make testcinder_jit goes from ~26m -> ~18m.
  • With a release build:
    • time make testcinder goes from ~6m15s -> ~4m45s.
    • time make testcinder_jit goes from ~6m -> ~5m30s.

While this is a bit hacky and annoyingly involves changing CPython test infra, I think the maintenance overhead is worth it. It's not a complicated change and I think the win in productivity with the diff above is significant.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Apr 25, 2023

The following commit authors need to sign the Contributor License Agreement:

  • r2q2@Balthazar

Click the button to sign:
CLA not signed

@zitterbewegung
Copy link
Contributor Author

Committed on wrong git account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant