Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-101520: Move tracemalloc functionality into core, leaving interface in Modules. #104508

Merged
merged 6 commits into from
May 17, 2023

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented May 15, 2023

This is a dumb refactoring.
All the new "API" functions are internal. They are marked PyAPI_FUNC for linkage.

Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos

Include/tracemalloc.h Outdated Show resolved Hide resolved
Include/tracemalloc.h Outdated Show resolved Hide resolved
Include/tracemalloc.h Outdated Show resolved Hide resolved
Include/tracemalloc.h Outdated Show resolved Hide resolved
Include/tracemalloc.h Outdated Show resolved Hide resolved
Include/tracemalloc.h Outdated Show resolved Hide resolved
Include/tracemalloc.h Outdated Show resolved Hide resolved
@markshannon
Copy link
Member Author

@Eclips4 Thanks for spotting those.

Python/pylifecycle.c Outdated Show resolved Hide resolved
@brandtbucher brandtbucher self-requested a review May 16, 2023 19:33
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (I didn't dig too closely into the moved code, but I'm trusting you that it's indeed a "dumb" refactoring).

Just one question on naming:

Include/tracemalloc.h Outdated Show resolved Hide resolved
Python/tracemalloc.c Outdated Show resolved Hide resolved
@markshannon markshannon merged commit f7df173 into python:main May 17, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 17, 2023
* main: (26 commits)
  pythonGH-101520: Move tracemalloc functionality into core, leaving interface in Modules. (python#104508)
  typing: Add more tests for TypeVar (python#104571)
  pythongh-104572: Improve error messages for invalid constructs in PEP 695 contexts (python#104573)
  typing: Use PEP 695 syntax in typing.py (python#104553)
  pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (python#102508)
  pythongh-104469: Update README.txt for _testcapi (pythongh-104529)
  pythonGH-103092: isolate `_elementtree` (python#104561)
  pythongh-104050: Add typing to Argument Clinic converters (python#104547)
  pythonGH-103906: Remove immortal refcounting in the interpreter (pythonGH-103909)
  pythongh-87474: Fix file descriptor leaks in subprocess.Popen (python#96351)
  pythonGH-103092: isolate `pyexpat`  (python#104506)
  pythongh-75367: Fix data descriptor detection in inspect.getattr_static (python#104517)
  pythongh-104050: Add more annotations to `Tools/clinic.py` (python#104544)
  pythongh-104555: Fix isinstance() and issubclass() for runtime-checkable protocols that use PEP 695 (python#104556)
  pythongh-103865: add monitoring support to LOAD_SUPER_ATTR (python#103866)
  CODEOWNERS: Assign new PEP 695 files to myself (python#104551)
  pythonGH-104510: Fix refleaks in `_io` base types (python#104516)
  pythongh-104539: Fix indentation error in logging.config.rst (python#104545)
  pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543)
  pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538)
  ...
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request May 18, 2023
@markshannon markshannon deleted the move-tracemalloc-to-core branch September 26, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants