-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-106259: add minimal help target to Makefile #106260
Conversation
What about putting the documentation there instead? https://docs.python.org/dev/using/configure.html#python-build-system |
My intent was to put more elaborate target documentation somewhere. Haven't started writing anything yet. Thanks for the suggested destination. |
I will look into that as well. Having a "make help" command you can execute when you just need a quick reminder is often helpful. And, it's always right at your fingertips. |
I made a quick, crude pass at expanding the makefile targets in |
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the change LGTM. I just have some minor remarks.
cc @erlend-aasland @corona10: Do you want to review these changes?
Any further comments on this @vstinner or @erlend-aasland, or can we push this to completion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some small bits and pieces:
Co-authored-by: Hugo van Kemenade <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I would prefer to sort targets in make list-targets
but it's a minor issue.
Thanks. Can someone merge? |
Merged, thanks @smontanaro! |
Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
Partially adding a help target, but partially just getting familiar @CAM-Gerlach's
git new
alias.