gh-106521: Remove _PyObject_LookupAttr() function #106642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
requested review from
rhettinger,
berkerpeksag,
erlend-aasland,
isidentical,
pganssle,
abalkin,
brettcannon,
ericsnowcurrently,
ncoghlan,
warsaw,
iritkatriel,
markshannon,
methane,
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
serhiy-storchaka
removed request for
berkerpeksag,
brettcannon,
methane,
warsaw,
1st1,
asvetlov and
ncoghlan
serhiy-storchaka
removed request for
iritkatriel,
ericsnowcurrently,
pganssle,
rhettinger,
willingc,
gvanrossum,
markshannon,
erlend-aasland,
isidentical,
kumaraditya303 and
abalkin
carljm
approved these changes
Jul 11, 2023
erlend-aasland
approved these changes
Jul 11, 2023
vstinner
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
LGTM.
You may change the change title to "Remove _PyObject_LookupAttr() function". In practice (in terms of C API), this change removes the function, since the previous change added a new function. I'm fine with removing private functions, but it seems like @encukou started to have concerns about such removals in Python 3.13 C API: see #106320
serhiy-storchaka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is an automatic replace in C files and
Parser/asdl_c.py.