Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-107091: Use :c:var: consistently for Py_Version #107063

Closed
wants to merge 5 commits into from
Closed

gh-107091: Use :c:var: consistently for Py_Version #107063

wants to merge 5 commits into from

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 22, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir labels Jul 22, 2023
@erlend-aasland erlend-aasland marked this pull request as draft July 22, 2023 19:53
@erlend-aasland erlend-aasland marked this pull request as ready for review July 22, 2023 21:50
serhiy-storchaka
serhiy-storchaka reviewed Jul 23, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opened #107091 for more general discussion.

@serhiy-storchaka serhiy-storchaka changed the title Docs: Use :c:var: consistently for Py_Version gh-107091: Docs: Use :c:var: consistently for Py_Version Jul 23, 2023
@erlend-aasland erlend-aasland mentioned this pull request Jul 23, 2023
Closed
vstinner
vstinner approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erlend-aasland erlend-aasland changed the title gh-107091: Docs: Use :c:var: consistently for Py_Version gh-107091: Use :c:var: consistently for Py_Version Jul 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 23, 2023
Closed
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 26, 2023
Closed
@vstinner vstinner mentioned this pull request Jul 26, 2023
Closed
@erlend-aasland
Copy link
Contributor Author

It looks to me this was recently fixed by using c:data; closing this PR.

@erlend-aasland erlend-aasland deleted the docs/py-version branch August 11, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
awaiting merge docs Documentation in the Doc dir needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @vstinner @serhiy-storchaka @bedevere-bot