Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-107091: Fix some uses of :c:type: role #107138

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 23, 2023

@@ -163,9 +163,9 @@ Quick Reference

.. [#cols] Columns:

**"O"**: set on :c:type:`PyBaseObject_Type`
**"O"**: set on :c:data:`PyBaseObject_Type`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:c:data:`PyBaseObject_Type` is also not found. Can it be documented or ab alternative used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is not currently documented. But this out of scope of this PR which simply fixes markup. When it be documented, all these reference will instantly became links.

@serhiy-storchaka serhiy-storchaka merged commit 6d5b6e7 into python:main Jul 26, 2023
21 checks passed
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the docs-c-type-role branch July 26, 2023 19:29
@bedevere-bot
Copy link

GH-107312 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2023
(cherry picked from commit 6d5b6e7)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 26, 2023
@bedevere-bot
Copy link

GH-107313 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2023
(cherry picked from commit 6d5b6e7)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 26, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 26, 2023
(cherry picked from commit 6d5b6e7)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Jul 26, 2023
(cherry picked from commit 6d5b6e7)

Co-authored-by: Serhiy Storchaka <[email protected]>
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants