Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-107091: Fix some uses of :const: role #107379

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 28, 2023

It is for references, not for literals.


📚 Documentation preview 📚: https://cpython-previews--107379.org.readthedocs.build/

It is for references, not for literals.
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The old usage of const looks suspicious and wrong. Congrats for fixing one more file in Doc/tools/.nitignore, for me a single fixed file is already a great success!

@serhiy-storchaka serhiy-storchaka merged commit 0aa58fa into python:main Jul 28, 2023
17 checks passed
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the docs-const-role branch July 28, 2023 10:26
@bedevere-bot
Copy link

GH-107384 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2023
It is for references, not for literals.
(cherry picked from commit 0aa58fa)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 28, 2023
@bedevere-bot
Copy link

GH-107385 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 28, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2023
It is for references, not for literals.
(cherry picked from commit 0aa58fa)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Jul 28, 2023
It is for references, not for literals.
(cherry picked from commit 0aa58fa)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka
Copy link
Member Author

Congrats for fixing one more file in Doc/tools/.nitignore, for me a single fixed file is already a great success!

Hold my beer. #107386

serhiy-storchaka added a commit that referenced this pull request Jul 28, 2023
It is for references, not for literals.
(cherry picked from commit 0aa58fa)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants