-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-107091: Fix some uses of :const: role #107379
gh-107091: Fix some uses of :const: role #107379
Conversation
It is for references, not for literals.
106973f
to
b97bfea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The old usage of const
looks suspicious and wrong. Congrats for fixing one more file in Doc/tools/.nitignore, for me a single fixed file is already a great success!
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
GH-107384 is a backport of this pull request to the 3.12 branch. |
It is for references, not for literals. (cherry picked from commit 0aa58fa) Co-authored-by: Serhiy Storchaka <[email protected]>
GH-107385 is a backport of this pull request to the 3.11 branch. |
It is for references, not for literals. (cherry picked from commit 0aa58fa) Co-authored-by: Serhiy Storchaka <[email protected]>
It is for references, not for literals. (cherry picked from commit 0aa58fa) Co-authored-by: Serhiy Storchaka <[email protected]>
Hold my beer. #107386 |
It is for references, not for literals. (cherry picked from commit 0aa58fa) Co-authored-by: Serhiy Storchaka <[email protected]>
It is for references, not for literals.
📚 Documentation preview 📚: https://cpython-previews--107379.org.readthedocs.build/