-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-109402: Fix regrtest findtests() #109403
Conversation
Check for the full module name in SPLITTESTDIRS, not the relative module name.
@sobolevn: Can you please check if this change fix your issue? |
Oh, sorry, I've missed this PR and opened another one: #109404 |
Does this change fix your issue? |
Steps to test this:
It works for me! Thanks! |
These test names are not helpful. Would it be possible to come with better names while we are moving code/renaming files anyway? |
Just from the name, it's not clear which test is testing the future statement... Both? Maybe propose a better name? |
Ignore my comments here, there were for PR #109368 :-) |
Good. I prefer to avoid isdir() if possible. |
Check for the full module name in SPLITTESTDIRS, not the relative module name.
regrtest
when name inSPLITTESTDIRS
also matches a module name in tests #109402