Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add os.splice flags argument #109847

Merged

Conversation

aminalaee
Copy link
Contributor

@aminalaee aminalaee commented Sep 25, 2023

The docs for os.splice misses the flags argument but it is documented in posixmodule.c:

cpython/Modules/posixmodule.c

Lines 11565 to 11566 in 64ab9f7

flags: unsigned_int = 0
Flags to modify the semantics of the call.

Ref: python/typeshed#10771


📚 Documentation preview 📚: https://cpython-previews--109847.org.readthedocs.build/

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 25, 2023
@aminalaee aminalaee changed the title Document os.splice flags argument Docs: Add os.splice flags argument Sep 25, 2023
Doc/library/os.rst Outdated Show resolved Hide resolved
Doc/library/os.rst Show resolved Hide resolved
Doc/library/os.rst Outdated Show resolved Hide resolved
Doc/library/os.rst Outdated Show resolved Hide resolved
Doc/library/os.rst Outdated Show resolved Hide resolved
@aminalaee aminalaee force-pushed the update-os-splice-docs-include-flags branch from 22d2e77 to 9405f2f Compare February 28, 2024 14:48
Copy link
Contributor

@blaisep blaisep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aminalaee , could you correct the missing space in the directive? AFAIK, everything else is very good.

Doc/library/os.rst Outdated Show resolved Hide resolved
@aminalaee aminalaee force-pushed the update-os-splice-docs-include-flags branch from 8a3a75e to cbbb2de Compare May 20, 2024 21:31
@kumaraditya303 kumaraditya303 merged commit 9d3c9b8 into python:main Jul 3, 2024
27 checks passed
@aminalaee aminalaee deleted the update-os-splice-docs-include-flags branch July 3, 2024 09:22
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Blaise Pabon <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Blaise Pabon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants