-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-110276: No longer ignore PROFILE_TASK failure silently #110295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR only touches the Makefile but, as I said in #110276 (comment), the problem also exists on Windows: I found locally that the test would fail but the build would still succeed. Windows builds don't use the Makefile.
PCbuild doesn't use Makefile nor PROFILE_TASK. If you consider that PCbuild also deserves a fix, please go ahead :-) I'm not comfortable to touch PCbuild/ directory. |
I suppose that the Windows code path is this line of PCbuild\build.bat:
No idea how to catch an error in BATCH :-) |
!buildbot PGO |
🤖 New build scheduled with the buildbot fleet by @vstinner for commit a26ba58 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
AMD64 RHEL8 LTO + PGO PR failed: https://buildbot.python.org/all/#/builders/378/builds/1199
It's an unrelated failure: #109959 |
This seems like it may have broken PGO on macOS: #110313 |
Aha, interesting bug. |
…on#110295) (cherry picked from commit 6ab6040)
GH-111950 is a backport of this pull request to the 3.12 branch. |
Now that test failures are no longer ignored, Python 3.13 builds on Rocky Linux 8 are now failing: #125067 |
test_unicode
always fails during a PGO-optimised build (because it does not exist) #110276📚 Documentation preview 📚: https://cpython-previews--110295.org.readthedocs.build/