Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-110276: No longer ignore PROFILE_TASK failure silently #110295

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 3, 2023

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only touches the Makefile but, as I said in #110276 (comment), the problem also exists on Windows: I found locally that the test would fail but the build would still succeed. Windows builds don't use the Makefile.

@vstinner
Copy link
Member Author

vstinner commented Oct 3, 2023

This PR only touches the Makefile but, as I said in #110276 (comment), the problem also exists on Windows: I found locally that the test would fail but the build would still succeed. Windows builds don't use the Makefile.

PCbuild doesn't use Makefile nor PROFILE_TASK. If you consider that PCbuild also deserves a fix, please go ahead :-) I'm not comfortable to touch PCbuild/ directory.

@vstinner
Copy link
Member Author

vstinner commented Oct 3, 2023

I suppose that the Windows code path is this line of PCbuild\build.bat:

    call "%dir%\..\python.bat" %pgo_job%

No idea how to catch an error in BATCH :-)

@vstinner
Copy link
Member Author

vstinner commented Oct 3, 2023

!buildbot PGO

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit a26ba58 🤖

The command will test the builders whose names match following regular expression: PGO

The builders matched are:

  • s390x RHEL8 LTO + PGO PR
  • PPC64LE RHEL8 LTO + PGO PR
  • PPC64LE Fedora Stable LTO + PGO PR
  • aarch64 Debian Clang LTO + PGO PR
  • AMD64 Debian PGO PR
  • AMD64 Fedora Stable LTO + PGO PR
  • aarch64 Fedora Stable LTO + PGO PR
  • s390x Fedora LTO + PGO PR
  • PPC64LE RHEL7 LTO + PGO PR
  • s390x RHEL7 LTO + PGO PR
  • aarch64 RHEL8 LTO + PGO PR
  • AMD64 RHEL8 LTO + PGO PR
  • AMD64 RHEL7 LTO + PGO PR

@vstinner
Copy link
Member Author

vstinner commented Oct 3, 2023

AMD64 RHEL8 LTO + PGO PR failed: https://buildbot.python.org/all/#/builders/378/builds/1199

FAIL: test_selflink (test.test_glob.SymlinkLoopGlobTests.test_selflink)

It's an unrelated failure: #109959

@vstinner vstinner merged commit 6ab6040 into python:main Oct 3, 2023
29 of 31 checks passed
@vstinner vstinner deleted the profile_task branch October 3, 2023 16:43
@mdboom
Copy link
Contributor

mdboom commented Oct 9, 2023

This seems like it may have broken PGO on macOS: #110313

@vstinner
Copy link
Member Author

This seems like it may have broken PGO on macOS: #110313

Aha, interesting bug.

vstinner added a commit to vstinner/cpython that referenced this pull request Nov 10, 2023
@bedevere-app
Copy link

bedevere-app bot commented Nov 10, 2023

GH-111950 is a backport of this pull request to the 3.12 branch.

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@JacobHenner
Copy link

Now that test failures are no longer ignored, Python 3.13 builds on Rocky Linux 8 are now failing: #125067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants