Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-111126: Use isinstance instead of assert[Not]IsInstance in test_typing #111127

Merged
merged 1 commit into from
Oct 20, 2023
Merged

gh-111126: Use isinstance instead of assert[Not]IsInstance in test_typing #111127

merged 1 commit into from
Oct 20, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 20, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 20, 2023
Closed
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Oct 20, 2023
@sobolevn sobolevn changed the title gh-111126: Use isintance instead of assert[Not]IsInstance in test_typing gh-111126: Use isinstance instead of assert[Not]IsInstance in test_typing Oct 20, 2023
AlexWaygood
AlexWaygood approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice improvement -- this makes the intention of the test clearer!

@JelleZijlstra JelleZijlstra added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Oct 20, 2023
@JelleZijlstra JelleZijlstra enabled auto-merge (squash) October 20, 2023 17:40
@JelleZijlstra JelleZijlstra merged commit ea7c26e into python:main Oct 20, 2023
29 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2023
@sobolevn @miss-islington
pythongh-111126: Use isinstance instead of assert[Not]IsInstance …
e9ebe4c 
…in `test_typing` (pythonGH-111127)

(cherry picked from commit ea7c26e)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2023
@sobolevn @miss-islington
pythongh-111126: Use isinstance instead of assert[Not]IsInstance …
222989c 
…in `test_typing` (pythonGH-111127)

(cherry picked from commit ea7c26e)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 20, 2023

GH-111130 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 20, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 20, 2023

GH-111131 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 20, 2023
AlexWaygood pushed a commit that referenced this pull request Oct 20, 2023
@miss-islington @sobolevn
[3.12] gh-111126: Use isinstance instead of assert[Not]IsInstance…
4a10260 
… in `test_typing` (GH-111127) (#111130)

gh-111126: Use `isinstance` instead of `assert[Not]IsInstance` in `test_typing` (GH-111127)
(cherry picked from commit ea7c26e)

Co-authored-by: Nikita Sobolev <[email protected]>
AlexWaygood pushed a commit that referenced this pull request Oct 20, 2023
@miss-islington @sobolevn
[3.11] gh-111126: Use isinstance instead of assert[Not]IsInstance…
9addf2c 
… in `test_typing` (GH-111127) (#111131)

gh-111126: Use `isinstance` instead of `assert[Not]IsInstance` in `test_typing` (GH-111127)
(cherry picked from commit ea7c26e)

Co-authored-by: Nikita Sobolev <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @aisk
pythongh-111126: Use isinstance instead of assert[Not]IsInstance …
8bae7a4 
…in `test_typing` (python#111127)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
pythongh-111126: Use isinstance instead of assert[Not]IsInstance …
5a36c0f 
…in `test_typing` (python#111127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @JelleZijlstra @gvanrossum @AlexWaygood