Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90815: Fix mimalloc atomic.h on Windows arm64 #111527

Merged
merged 1 commit into from
Oct 30, 2023
Merged

gh-90815: Fix mimalloc atomic.h on Windows arm64 #111527

merged 1 commit into from
Oct 30, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 30, 2023 •
edited by bedevere-app bot
Loading

mi_atomic_load_explicit() casts 'p' argument to drop the 'const' qualifier on Windows arm64 platform. Fix the compiler warning:

'function': different 'const' qualifiers
(compiling source file ..\Objects\mimalloc\options.c)

@vstinner
pythongh-90815: Fix mimalloc atomic.h on Windows arm64
2d4815c 
mi_atomic_load_explicit() casts 'p' argument to drop the 'const'
qualifier on Windows arm64 platform. Fix the compiler warning:

    'function': different 'const' qualifiers
    (compiling source file ..\Objects\mimalloc\options.c)
@bedevere-app bedevere-app bot mentioned this pull request Oct 30, 2023
Closed
@vstinner
Copy link
Member Author

cc @DinoV

@vstinner vstinner enabled auto-merge (squash) October 30, 2023 22:23
@vstinner
Copy link
Member Author

Tests / Hypothesis tests on Ubuntu (pull_request) Failing after 7m

FAIL: test_timerfd_poll (test.test_os.TimerfdTests.test_timerfd_poll) failed: it's unrelated.

I created #111529 to fix the test.

@vstinner vstinner merged commit 801741f into python:main Oct 30, 2023
29 of 30 checks passed
@vstinner vstinner deleted the mimalloc_win_arm64 branch October 30, 2023 22:33
@vstinner vstinner mentioned this pull request Oct 31, 2023
Merged
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@vstinner @FullteaR
pythongh-90815: Fix mimalloc atomic.h on Windows arm64 (python#111527)
25dd725 
mi_atomic_load_explicit() casts 'p' argument to drop the 'const'
qualifier on Windows arm64 platform. Fix the compiler warning:

    'function': different 'const' qualifiers
    (compiling source file ..\Objects\mimalloc\options.c)
@colesbury colesbury mentioned this pull request Dec 14, 2023
Open
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@vstinner @aisk
pythongh-90815: Fix mimalloc atomic.h on Windows arm64 (python#111527)
d007c5b 
mi_atomic_load_explicit() casts 'p' argument to drop the 'const'
qualifier on Windows arm64 platform. Fix the compiler warning:

    'function': different 'const' qualifiers
    (compiling source file ..\Objects\mimalloc\options.c)
daanx added a commit to microsoft/mimalloc that referenced this pull request May 18, 2024
@daanx
fix arm64 windows compilation, upstream of python/cpython#111527
c48a212
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-90815: Fix mimalloc atomic.h on Windows arm64 (python#111527)
bd9bc57 
mi_atomic_load_explicit() casts 'p' argument to drop the 'const'
qualifier on Windows arm64 platform. Fix the compiler warning:

    'function': different 'const' qualifiers
    (compiling source file ..\Objects\mimalloc\options.c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vstinner